Skip to content

fix(test-specs): parenthesize walrus when counting failing txs #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuiweixie wants to merge 1 commit into
base: forks/amsterdam
Choose a base branch
from
+1 −1
Open

fix(test-specs): parenthesize walrus when counting failing txs #3190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/testing/src/execution_testing/specs/blockchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ def generate_block_data(
]
txs = [tx.with_signature_and_sender() for tx in txs]

if failing_tx_count := len([tx for tx in txs if tx.error]) > 0:
if (failing_tx_count := len([tx for tx in txs if tx.error])) > 0:
if failing_tx_count > 1:
raise Exception(
"test correctness: only one transaction can produce "
Expand Down
Loading