chore(ci): deduplicate temp-dir creation across Justfile recipes#3191
Open
knQzx wants to merge 1 commit into
Open
chore(ci): deduplicate temp-dir creation across Justfile recipes#3191knQzx wants to merge 1 commit into
knQzx wants to merge 1 commit into
Conversation
Ten recipes each repeated an inline mkdir for their pytest --basetemp scratch directory (and, for the fill/bench recipes, a logs directory). Replace the repetition with two private recipes, _tmp and _tmp-logs, that recipes depend on, e.g. `fill *args: (_tmp-logs "fill")`. Keeping the name as a dependency argument avoids the recipe_name() function and the just >=1.53 bump it would require. Closes ethereum#3112
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3191 +/- ##
================================================
Coverage 93.39% 93.39%
================================================
Files 624 624
Lines 37014 37014
Branches 3386 3386
================================================
Hits 34570 34570
Misses 1671 1671
Partials 773 773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ten recipes each repeated an inline mkdir for their
--basetempscratch dir (and a logs dir for the fill/bench ones). replaced with two private recipes,_tmpand_tmp-logs, that recipes depend on, e.g.fill *args: (_tmp-logs "fill")passing the name as a dependency argument avoids
recipe_name()and the just >=1.53 bump it would needRelated Issues or PRs
fixes #3112