Skip to content

feat(test-forks): Over-length secured-trie leaf path: 67 nibbles (currently accepted)#3193

Open
pirapira wants to merge 1 commit into
ethereum:projects/zkevmfrom
pirapira:witness-overlength-fixture
Open

feat(test-forks): Over-length secured-trie leaf path: 67 nibbles (currently accepted)#3193
pirapira wants to merge 1 commit into
ethereum:projects/zkevmfrom
pirapira:witness-overlength-fixture

Conversation

@pirapira

Copy link
Copy Markdown
Member

Description

This PR adds a new fixture for zkevm tests. The new fixture contains mpt witness with a leaf path of 67 nibbles. This is currently accepted, but would be rejected on stateless guests with length checks on mpt paths (like suggested in #3155).

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

"backyard bandits - baby racoons" by Christian Collins is licensed under CC BY-SA 2.0. To view a copy of this license, visit https://creativecommons.org/licenses/by-sa/2.0/?ref=openverse.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (8093f58) to head (8a18c85).
⚠️ Report is 1 commits behind head on projects/zkevm.

Additional details and impacted files
@@               Coverage Diff               @@
##           projects/zkevm    #3193   +/-   ##
===============================================
  Coverage           92.68%   92.68%           
===============================================
  Files                 638      638           
  Lines               38214    38214           
  Branches             3573     3573           
===============================================
  Hits                35419    35419           
  Misses               1914     1914           
  Partials              881      881           
Flag Coverage Δ
unittests 92.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pirapira

Copy link
Copy Markdown
Member Author

CI failure seems to be on projects/zkevm branch already.

  git fetch origin projects/zkevm
  git worktree add /tmp/execution-specs-zkevm origin/projects/zkevm
  cd /tmp/execution-specs-zkevm
  git submodule update --init --recursive

  just fill --from Amsterdam --until Amsterdam \
    -m "not slow and not derived_test"

fails locally for me at 48247ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant