feat(test-benchmark): add deployment contract script, no-rewind flag#3194
feat(test-benchmark): add deployment contract script, no-rewind flag#3194LouisTsai-Csie wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devnets/glamsterdam/6-benchmarks #3194 +/- ##
===================================================================
Coverage ? 93.30%
===================================================================
Files ? 624
Lines ? 36986
Branches ? 3383
===================================================================
Hits ? 34508
Misses ? 1695
Partials ? 783
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| return base + base // 16 + EXECUTION_GAS_BUFFER | ||
|
|
||
|
|
||
| def test_deploy_existing_contracts( |
There was a problem hiding this comment.
Iiuc (from the PR description) this test function is not really a test, rather it's a helper that is used to deploy contracts, and then the --no-reset-between-tests flag is used to run the actual tests. Is this correct?
If so, I think there has to be a better way to accomplish this, because we are basically overloading the test function to perform other tasks, rather than describing the test pre-requisites inside of the tests that need them.
Description
Based on benchmarking call. This PR is not needed for now.
This PR adds two features:
test_account_accessandtest_ether_transfers_on_receiversnormally rely on state-actor for account/contract generation. This PR addstest_setup_contractto manually deploy necessary contracts and delegated accounts when state-actor is unavailable.--no-reset-between-teststo skip rewinding the client head between tests. By default, benchmarks rewind tostart_blockafter each test; this flag allows state to accumulate across tests.Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture