bug(test-client-clis): pass str to shutil.which for Windows support#3211
Open
Kumarutkarsh9470 wants to merge 1 commit into
Open
bug(test-client-clis): pass str to shutil.which for Windows support#3211Kumarutkarsh9470 wants to merge 1 commit into
Kumarutkarsh9470 wants to merge 1 commit into
Conversation
`EthereumCLI.__init__` and `is_installed` passed a `Path` to `shutil.which`. On Windows under Python 3.11 (a supported version) `shutil.which` calls `.lower()` on the argument, so a `Path` raises `AttributeError` instead of resolving the binary. Convert the path to `str` at both call sites and add tests covering a `Path` binary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EthereumCLI.__init__andis_installedpassed aPathtoshutil.which. On Windows under Python 3.11 (a supported version)shutil.whichcalls.lower()on the argument, so aPathraisesAttributeErrorinstead of resolving the binary. Convert the path tostrat both call sites and add tests covering aPathbinary.Description
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture