ci: drop NODE_AUTH_TOKEN in favor of npm trusted publishing#300
Merged
Conversation
The publish_npmjs workflow already runs with id-token: write under the publish environment, and the package is registered as a trusted publisher on npmjs.com. Removing NODE_AUTH_TOKEN lets npm publish authenticate via OIDC instead of the long-lived NPM_TOKEN secret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_AUTH_TOKEN/NPM_TOKENenv from thenpm publishstep inpublish_npmjs.yaml.id-token: writeunder thepublishenvironment, and@ethersphere/bee-factoryis registered as a trusted publisher on npmjs.com for this repo / workflow / environment.npm publish --provenancewill authenticate via OIDC.Test plan
publish_npmjs.yamlNPM_TOKENand the package appears on npm with a provenance attestation