feat: add support for stateful fixture format#182
Closed
fselmo wants to merge 1 commit into
Closed
Conversation
3 tasks
skylenet
added a commit
that referenced
this pull request
May 12, 2026
## Summary Cherry-picked from the second commit of #182 (`4439298`, by @fselmo). Adds a `git-repo` input to the composite action so CI workflows triggered by PRs from forks clone the fork's HEAD instead of always cloning `ethpandaops/benchmarkoor`. The workflow wires `github.event.pull_request.head.repo.clone_url` into that input and uses `head.repo.full_name` in the `run-config-urls` so the runtime config files are also fetched from the fork. ## Test plan - [ ] Open a PR from a fork against this branch and confirm the CI action clones the fork (the workflow log should show `Cloning https://github.com/<fork-owner>/benchmarkoor.git at ref <sha>`). - [ ] Verify the `run-config-urls` resolve to `raw.githubusercontent.com/<fork-owner>/benchmarkoor/<sha>/...` rather than the canonical repo path. - [ ] PRs from branches inside `ethpandaops/benchmarkoor` should continue to clone the canonical repo unchanged. Co-authored-by: Felipe Selmo <fselmo2@gmail.com>
fselmo
force-pushed
the
fill-stateful-tests
branch
from
4439298 to
f32f5a5
Compare
|
Note to self: This commit ethereum/execution-specs@fbc39ad could have broken this PR, need to double check. |
9 tasks
Contributor
Author
Just checked and this doesn't seem to have broken anything 👀 |
Member
|
closing this in favour of #248 which is progressing nicely and already supports state-actor + fill-stateful from the execution-specs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes go together with the execution-specs PR here.
I will leave this as a draft until the design / approach is settled there as some of this flow may change.[this is aligned with the current state inexecution-specsnow].The main goal here is to be able to read the pre-run file, apply these things before setting the checkpoint, and then be able to read the new stateful fixture format and run these tests with benchmarkoor.
The current state of this flow has been tested and is working but some of these interactions may change, as mentioned above.
cc: @LouisTsai-Csie