fix(build-summary): mount schelk before rendering so a skipped state-actor shows its data#270
Merged
Merged
Conversation
…tor shows data The build markdown summary renders each target from its on-disk output_dir (state-actor manifest, eest fill sidecar). A state-actor datadir promoted onto a schelk mount is left unmounted, so by the time the separate generate-build-markdown-summary step runs, its manifest reads as missing — a skipped state-actor target then showed only Status/Client/Elapsed, with no fork, state root, image, account counts, or db size. generate-build-markdown-summary now ensures the schelk scratch is mounted (for any output_dir under a schelk mount) before rendering, via a new exported executor.ReadBuildSummary. Best-effort; a non-schelk host is a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
In the GitHub Action's build summary, a skipped state-actor target shows only
Status: Skipped,Client, andElapsed— no fork, state root, docker image, account/contract/storage counts, or DB size. The eest-payloads section on the same run shows full data.Root cause
The build markdown summary is rendered by a separate
generate-build-markdown-summarystep that reads each target's on-diskoutput_dir(state-actorstate-actor-manifest.json, eest.benchmarkoor-fill.json). The state-actoroutput_dirlives under a schelk mount (/schelk/state-actor/v1/nethermind); a promoted state-actor datadir is left unmounted (schelk promote). So when the render step runs after the build, the manifest reads as missing → the renderer shows nothing beyond the fields already inbuild-summary.json(status/client/elapsed).The eest section is fine because its fill sidecar isn't under schelk.
Fix
generate-build-markdown-summarynow ensures the schelk scratch is mounted before rendering, when any target'soutput_diris under a schelk mount:executor.ReadBuildSummary(path)(also used byGenerateBuildMarkdownnow).output_diris schelk-backed, callsdatadir.EnsureSchelkMountedonce (one volume covers all). Best-effort — a non-schelk host or unreadable summary is a no-op; a mount failure logs a warning and renders what it can (no regression).The render step already runs with
sudo -Ein the action, so it can mount.The executor stays free of a
datadirdependency — the schelk-ensure lives in the cmd layer.Tests / validation
GenerateBuildMarkdownrefactored ontoReadBuildSummary);go build/go testgreen; golangci-lint--new-from-rev=origin/master0 issues.benchmarkoor-testsre-run.