feat(runner): fixtures_url standalone mode + GitHub artifact URL support#274
Merged
Conversation
fixtures_url can now be a standalone eest_fixtures source (when github_release is unset), pointing at either: - a release/plain .tar.gz URL, or - a GitHub Actions artifact URL (github.com/<owner>/<repo>/actions/runs/<run>/artifacts/<id>), downloaded via the API (needs runner.github_token) with its inner .tar.gz extracted — so a benchmarkoor build artifact can be consumed directly. fixtures_subdir points at the fixtures within; no genesis is fetched (stateful-engine fixtures boot from the snapshot datadir). When github_release is set, fixtures_url keeps acting as the release-URL override. The by-id artifact download is shared with the existing artifact-name mode (downloadArtifactZip).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
eest_fixtures.fixtures_urla standalone source (whengithub_releaseis unset), pointing at either:.tar.gzURL, orgithub.com/<owner>/<repo>/actions/runs/<run>/artifacts/<id>) — downloaded via the GitHub API (needsrunner.github_token), unzipped, and its **inner.tar.gzauto-extracted`.fixtures_subdirpoints at the fixtures within; no genesis is fetched (stateful-engine fixtures boot from the snapshot datadir). Whengithub_releaseis set,fixtures_urlkeeps its existing role as the release-URL override.This lets you consume a benchmarkoor build artifact directly:
…and any plain tarball URL (e.g. a benchmarkoor-tests release asset) works with no token.
How
config:UseFixturesURL()(fixtures_url set & no github_release) as a new mode invalidate(); nogithub_reporequired for URL mode.executor:prepareFromURL→downloadFromURLauto-detects artifact-vs-plain viaparseGitHubArtifactURL; artifact URLs reuse a new shareddownloadArtifactZip(by owner/repo/id), plain URLs reusedownloadAndExtractTarball. The artifact-name mode now uses the samedownloadArtifactZip(dedup).Tests / docs
TestParseGitHubArtifactURL(artifact vs release vs plain) +TestEESTFixturesSource_UseFixturesURL(mode + validation).go build/go testgreen (except the pre-existing macOS-only/proc/mountsschelk test); golangci-lint--new-from-rev=origin/master0 issues.docs/configuration.mdupdated:fixtures_urldescription,github_reponowYes*, mode note, and a standalone-URL example.