Skip to content

fix validatator name filter on missed slots#711

Merged
barnabasbusa merged 1 commit into
masterfrom
pk910/fix-filtered-slots-view
May 22, 2026
Merged

fix validatator name filter on missed slots#711
barnabasbusa merged 1 commit into
masterfrom
pk910/fix-filtered-slots-view

Conversation

@pk910
Copy link
Copy Markdown
Member

@pk910 pk910 commented May 21, 2026

Show missed slots when filtering by proposer index or name

Summary

  • The shouldCheckMissing gate in ChainService.GetDbBlocksByFilter was disabling reconstruction of missed slots from epoch duties whenever a ProposerIndex or ProposerName filter was set, so the filtered slots view never showed missed slots for a specific validator.
  • Proposer-based filters are evaluated against epoch duty assignments and are perfectly compatible with reconstructed missing slots — the extra terms were incorrect.
  • Drop filter.ProposerIndex == nil && filter.ProposerName == "" from the shouldCheckMissing condition so missed slots appear for proposer-filtered queries.

Root cause

Both terms were introduced unintentionally during a mastergloas-support merge conflict resolution in 128a7f66 ("Merge branch 'master' into gloas-support", Feb 10 2026). Two diverging tails of the shouldCheckMissing expression were concatenated and && filter.ProposerIndex == nil && filter.ProposerName == "" was tacked on, with the whole tail duplicated. The duplication was cleaned up in a later commit, but the bogus proposer terms remained.

@barnabasbusa barnabasbusa merged commit e410ee3 into master May 22, 2026
2 checks passed
@barnabasbusa barnabasbusa deleted the pk910/fix-filtered-slots-view branch May 22, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants