refactor(ci): improve harbor registry deployment and manifest pushing… (#329)

… logic

Remove redundant tagging in image build step and move harbor pushing to
a best-effort step. Add explicit login for harbor registry in both
deploy and manifest actions. This simplifies image tagging during the
build and ensures manifest pushing to harbor is non-blocking.

Author: barnabasbusa

.github/actions/deploy/action.yml

@@ -126,6 +126,8 @@ runs:
       password: ${{ inputs.DOCKER_PASSWORD }}
   - name: Login to harbor registry
     if: ${{ inputs.harbor_registry != '' }}
+    id: harbor_login
+    continue-on-error: true
     uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
     with:
       registry: ${{ inputs.harbor_registry }}
@@ -180,14 +182,9 @@ runs:
     with:
       context: ./source
       file: ${{ inputs.target_dockerfile }}
-      # two tags;
-      #   - $target_tag
-      #   - $target_tag-commit
       tags: |
         ${{ inputs.target_repository }}:${{ inputs.target_tag }}-${{ steps.git_commit_hash.outputs.git_commit_hash }}
         ${{ inputs.target_repository }}:${{ inputs.target_tag }}
-        ${{ inputs.harbor_registry != '' && format('{0}/{1}:{2}-{3}', inputs.harbor_registry, inputs.target_repository, inputs.target_tag, steps.git_commit_hash.outputs.git_commit_hash) || '' }}
-        ${{ inputs.harbor_registry != '' && format('{0}/{1}:{2}', inputs.harbor_registry, inputs.target_repository, inputs.target_tag) || '' }}
       push: true
       platforms: ${{ inputs.platform }}
       build-args: |
@@ -199,6 +196,16 @@ runs:
         commit=${{ steps.git_commit_hash.outputs.git_commit_hash }}
         version=${{ inputs.source_ref }}
         buildnum=${{ github.run_number }}
+  - name: Push to harbor registry (best-effort)
+    if: ${{ inputs.build_script == '' && inputs.harbor_registry != '' && steps.harbor_login.outcome == 'success' }}
+    continue-on-error: true
+    shell: bash
+    run: |
+      echo "Pushing to harbor registry (best-effort)..."
+      docker buildx imagetools create \
+        --tag ${{ inputs.harbor_registry }}/${{ inputs.target_repository }}:${{ inputs.target_tag }}-${{ steps.git_commit_hash.outputs.git_commit_hash }} \
+        --tag ${{ inputs.harbor_registry }}/${{ inputs.target_repository }}:${{ inputs.target_tag }} \
+        ${{ inputs.target_repository }}:${{ inputs.target_tag }}-${{ steps.git_commit_hash.outputs.git_commit_hash }} || echo "Harbor push failed, continuing..."
   - name: Image digest & tags
     shell: bash
     if: ${{ inputs.build_script == '' }}

.github/actions/manifest/action.yml

@@ -98,9 +98,28 @@ runs:
     with:
       username: ${{ inputs.DOCKER_USERNAME }}
       password: ${{ inputs.DOCKER_PASSWORD }}
+  - name: Login to harbor registry
+    if: ${{ inputs.harbor_registry != '' }}
+    id: harbor_login
+    continue-on-error: true
+    uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
+    with:
+      registry: ${{ inputs.harbor_registry }}
+      username: ${{ inputs.HARBOR_USERNAME }}
+      password: ${{ inputs.HARBOR_PASSWORD }}
 
   - name: Create and push manifest images to dockerhub
     shell: bash
     run: |
       docker buildx imagetools create --dry-run -t ${{ inputs.target_repository }}:${{ inputs.target_tag }} -t ${{ inputs.target_repository }}:${{ inputs.target_tag }}-${{ inputs.git_commit_hash }} ${{ steps.generate_images_list.outputs.images }}
       docker buildx imagetools create -t ${{ inputs.target_repository }}:${{ inputs.target_tag }} -t ${{ inputs.target_repository }}:${{ inputs.target_tag }}-${{ inputs.git_commit_hash }} ${{ steps.generate_images_list.outputs.images }}
+  - name: Create and push manifest images to harbor (best-effort)
+    if: ${{ inputs.harbor_registry != '' && steps.harbor_login.outcome == 'success' }}
+    continue-on-error: true
+    shell: bash
+    run: |
+      echo "Pushing manifest to harbor registry (best-effort)..."
+      docker buildx imagetools create \
+        -t ${{ inputs.harbor_registry }}/${{ inputs.target_repository }}:${{ inputs.target_tag }} \
+        -t ${{ inputs.harbor_registry }}/${{ inputs.target_repository }}:${{ inputs.target_tag }}-${{ inputs.git_commit_hash }} \
+        ${{ steps.generate_images_list.outputs.images }} || echo "Harbor manifest push failed, continuing..."