fix(docker-tag): force lowercase for repository and tag inputs#375
Merged
Conversation
Repository name comparisons were case-sensitive, so dispatching with the actual GitHub-cased `OffchainLabs/prysm` did not match the `offchainlabs/prysm` upstream and produced an `OffchainLabs-` prefix on the resulting tag. Lowercase all inputs before comparing and emitting the tag so prefix detection is case-insensitive and tags stay lowercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-tagcomposite action comparedrepositoryandupstream_repositorycase-sensitively, so dispatching prysm with the actual GitHub-casedOffchainLabs/prysmdid not match theoffchainlabs/prysmupstream and produced anOffchainLabs-prefix (e.g.OffchainLabs-glamsterdam-devnet-3-minimal).input,repository,upstream_repository,docker_tag) before comparing and emitting the tag. Prefix detection becomes case-insensitive and tags stay fully lowercase across every workflow that uses this action.Test plan
Build prysm docker imagewithrepository=OffchainLabs/prysmand confirm nooffchainlabs-prefix is added to the resulting tag.MarcoPolo/prysm) and confirm the prefix is still applied asmarcopolo-.