Skip to content

Bump Java to 25 for teku and besu builds#380

Merged
barnabasbusa merged 3 commits into
masterfrom
claude/fix-github-actions-oj9ay
May 18, 2026
Merged

Bump Java to 25 for teku and besu builds#380
barnabasbusa merged 3 commits into
masterfrom
claude/fix-github-actions-oj9ay

Conversation

@barnabasbusa
Copy link
Copy Markdown
Collaborator

@barnabasbusa barnabasbusa commented May 17, 2026

Summary

  • Teku master upgraded targetJavaVersion to Java 25 (consensys/teku#10567), causing the scheduled teku build to fail with the JDK 21 currently installed by install-deps.
  • Bumps both teku and besu to JDK 25. Besu still pins sourceCompatibility = 21 but builds fine on a newer JDK.

Fixes the failure in run 25982909839.

Test plan

  • Trigger a teku master build on this branch and confirm it succeeds. — run 26029821633 ✅ (amd64 + arm64 + manifest, tag jdk25-test-147ba3)
  • Trigger a besu main build on this branch and confirm it succeeds. — run 26029819949 ✅ (amd64 + arm64 + manifest, tag jdk25-test-147ba3)

Generated by Claude Code

claude added 2 commits May 17, 2026 06:44
Teku master upgraded its targetJavaVersion to Java 25, so the
install-deps action needs to provide a matching JDK or the
gradle build fails.
Match the teku bump so both JVM clients use the same JDK. Besu
still pins source/target compatibility to 21, but JDK 25 is
forward-compatible at compile time.
@barnabasbusa barnabasbusa marked this pull request as ready for review May 18, 2026 11:06
@qu0b-reviewer
Copy link
Copy Markdown

qu0b-reviewer Bot commented May 18, 2026

🤖 qu0b-reviewer

Looks good — clean bump + a well-scoped syntax refactor. No blockers. 🦋

Java 25: No known advisories for Temurin/OpenJDK 25. Forward compatibility claim (target stays at 21 for Besu) is correct — JDK 25 can build code targeting 21 just fine.

: override syntax: Consistent — two split(':', 1) calls (main branches + alt_repos), both using maxsplit=1. The alt_repos path also correctly prepends the repo prefix to the override tag, matching the existing pattern for non-overridden branches.


Reviewed @ b190a7b7

@barnabasbusa barnabasbusa enabled auto-merge (squash) May 18, 2026 11:23
@barnabasbusa barnabasbusa merged commit e3310e7 into master May 18, 2026
3 checks passed
@barnabasbusa barnabasbusa deleted the claude/fix-github-actions-oj9ay branch May 18, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants