-
Notifications
You must be signed in to change notification settings - Fork 25
Improve prover setup #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve prover setup #112
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,11 @@ | |
| pragma solidity 0.8.24; | ||
|
|
||
| import { Constants } from "../libraries/Constants.sol"; | ||
| import { Predeploys } from "../libraries/Predeploys.sol"; | ||
|
|
||
| interface IEthscriptionsProver { | ||
| function flushAllProofs() external; | ||
| } | ||
|
|
||
| /// @custom:proxied | ||
| /// @custom:predeploy 0x4200000000000000000000000000000000000015 | ||
|
|
@@ -80,5 +85,9 @@ contract L1Block { | |
| sstore(hash.slot, calldataload(100)) // bytes32 | ||
| sstore(batcherHash.slot, calldataload(132)) // bytes32 | ||
| } | ||
|
|
||
| // Flush all queued ethscription proofs after updating block values | ||
| // Each proof includes its own block number and timestamp from when it was queued | ||
| IEthscriptionsProver(Predeploys.ETHSCRIPTIONS_PROVER).flushAllProofs(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: L1 Block Update Fails on Prover ErrorThe |
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
proofInfoparameter should be passed by value (memory) instead of by reference (storage) since it's only being read and doesn't need to be modified. Usingstorageunnecessarily keeps a reference to storage which is less gas efficient for read-only operations.