Use IPC instead of HTTP for performance#120
Merged
Merged
Conversation
| :ipc | ||
| else | ||
| :http | ||
| end |
There was a problem hiding this comment.
Bug: IPC Detection Fails on HTTP URLs
The detect_mode method might incorrectly classify HTTP URLs as IPC. This happens because its IPC detection logic, specifically checking for '.ipc' in the URL string and using File.socket? on potentially unstripped HTTP URLs, can lead to misidentification. This can cause the client to attempt IPC connections to HTTP endpoints, resulting in connection failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Switches RPC to a new EthRpcClient with IPC/JWT engine support, adds memoized GethDriver.get_l1_attributes, updates call sites, and removes GethClient.
EthRpcClient.l2_enginefor authenticated engine calls.clienttoEthRpcClient.l2_engine,non_auth_clienttoEthRpcClient.l2; add memoizedget_l1_attributes(l2_block_number)(moved from old client).GethDriver.client.get_l1_attributes(...)withGethDriver.get_l1_attributes(...)inapp/jobs/gap_detection_job.rbandapp/services/eth_block_importer.rb.lib/geth_client.rb.Written by Cursor Bugbot for commit 29dc822. This will update automatically on new commits. Configure here.