Simplify tokens#124
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the token system by removing the protocol field from the TokenInfo struct since it always stores "erc-20" for TokenManager. The protocol value is now hardcoded where needed instead of being stored.
Key Changes:
- Removed
protocolfield fromTokenInfostruct in TokenManager contract - Inlined the
_deployTokenhelper function intohandleDeploysince protocol is now constant - Updated Ruby token reader to hardcode protocol as "erc-20" instead of decoding it
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contracts/src/TokenManager.sol | Removed protocol field from TokenInfo struct and inlined _deployToken function |
| contracts/test/EthscriptionsToken.t.sol | Removed assertion for protocol field since it's no longer stored |
| lib/token_reader.rb | Updated ABI decoder to remove protocol field and hardcode it to "erc-20" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Removes
protocolfromTokenInfo, inlines deploy logic inop_deploy, and updates Ruby reader and tests to the new ABI/layout.contracts/src/TokenManager.sol):protocolfromTokenInfoand related storage/writes.op_deploy; remove_deployToken.protocol; mapdeployToTickand emitTokenDeployedas before.getTokenInfo*tuple changed (protocol string removed; field order shifted).contracts/test/EthscriptionsToken.t.sol):tokenInfo.protocolto match new struct.lib/token_reader.rb):TokenInfo(remove protocol field, adjust indices).protocol: 'erc-20'client-side; keepmintLimitmapped frommintAmount.Written by Cursor Bugbot for commit 887867f. This will update automatically on new commits. Configure here.