Big rename#127
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive rename from "token"/"TokenManager"/"erc-20" terminology to "fixed-fungible"/"FixedFungibleProtocolHandler"/"fixed-fungible" across the codebase. The changes reflect a protocol rename to better describe the underlying token mechanics.
Key Changes:
- Renamed
TokenManagercontract toFixedFungibleProtocolHandlerand updated all event names - Changed protocol identifier from "erc-20" to "fixed-fungible" throughout the codebase
- Updated class names:
TokenParamsExtractor→FixedFungibleTokenParamsExtractor,TokenReader→FixedFungibleReader - Renamed ERC-20/ERC-721 template contracts and collections handler to align with new naming
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/models/protocol_extractor_spec.rb | Updated test expectations for protocol type and name changes |
| spec/models/generic_protocol_extractor_spec.rb | Updated test context and extractor class references |
| spec/models/fixed_fungible_token_params_extractor_spec.rb | Renamed spec file and updated all class references |
| spec/models/ethscription_transaction_builder_spec.rb | Updated extractor class name and expected protocol values |
| spec/integration/tokens_protocol_spec.rb | Updated reader class references and protocol expectations |
| spec/integration/token_protocol_e2e_spec.rb | Updated event names, reader references, and comments |
| lib/tasks/genesis.rake | Simplified task implementation |
| lib/sys_config.rb | Renamed constant and accessor method |
| lib/protocol_event_reader.rb | Updated event signatures and parser method names |
| lib/fixed_fungible_reader.rb | Renamed class and updated protocol value |
| contracts/test/*.t.sol | Updated contract references, constant names, and type names across all test files |
| contracts/src/libraries/Predeploys.sol | Renamed predeploy constants and updated comments |
| contracts/src/FixedFungibleProtocolHandler.sol | Renamed contract and updated event/constant names |
| contracts/src/FixedFungibleERC20.sol | Renamed contract and updated access control references |
| contracts/src/CollectionsProtocolHandler.sol | Renamed contract and template reference |
| contracts/src/CollectionsERC721.sol | Updated manager class references |
| contracts/script/L2Genesis.s.sol | Updated protocol registration and predeploy references |
| app/models/protocol_extractor.rb | Updated extractor class references and protocol identifiers |
| app/models/generic_protocol_extractor.rb | Updated helper method implementation |
| app/models/fixed_fungible_token_params_extractor.rb | Renamed class and added protocol pattern matching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Renames ERC-20 TokenManager-based flow to a FixedFungible protocol/handler and updates collections contracts, extractors, predeploys, readers, genesis, and tests to the new names and events.
TokenParamsExtractor→FixedFungibleTokenParamsExtractor; supportpoferc-20|fixed-fungible; updateProtocolExtractorto type:fixed_fungible, protocolfixed-fungible, and ABI encoding comments.GenericProtocolExtractor.extract_token_paramsnow uses the new extractor.FixedFungibleProtocolHandlerandFixedFungibleERC20; emitFixedFungibleToken{Deployed,Minted,Transferred}; update template/constants usage.CollectionsManager→CollectionsProtocolHandler;EthscriptionERC721→CollectionsERC721; update all calls/usages.TOKEN_MANAGER/ERC20/721 template andCOLLECTIONS_MANAGERwithFIXED_FUNGIBLE_HANDLER,FIXED_FUNGIBLE_TEMPLATE_IMPLEMENTATION, andCOLLECTIONS_PROTOCOL_HANDLER.L2Genesis.s.solto set code and registerfixed-fungibleand new collections handler.TokenReaderwithFixedFungibleReader; switch addresses and event parsing inProtocolEventReader; updateSysConfigconstants.genesis.raketask.fixed-fungible) where applicable.Written by Cursor Bugbot for commit 83e4f49. This will update automatically on new commits. Configure here.