Skip to content

Big rename#127

Merged
RogerPodacter merged 2 commits into
evm-backend-demofrom
rename
Oct 22, 2025
Merged

Big rename#127
RogerPodacter merged 2 commits into
evm-backend-demofrom
rename

Conversation

@RogerPodacter

@RogerPodacter RogerPodacter commented Oct 22, 2025

Copy link
Copy Markdown
Member

Note

Renames ERC-20 TokenManager-based flow to a FixedFungible protocol/handler and updates collections contracts, extractors, predeploys, readers, genesis, and tests to the new names and events.

  • Protocols/Extractors:
    • Rename TokenParamsExtractorFixedFungibleTokenParamsExtractor; support p of erc-20|fixed-fungible; update ProtocolExtractor to type :fixed_fungible, protocol fixed-fungible, and ABI encoding comments.
    • GenericProtocolExtractor.extract_token_params now uses the new extractor.
  • Contracts:
    • Add FixedFungibleProtocolHandler and FixedFungibleERC20; emit FixedFungibleToken{Deployed,Minted,Transferred}; update template/constants usage.
    • Rename collections: CollectionsManagerCollectionsProtocolHandler; EthscriptionERC721CollectionsERC721; update all calls/usages.
  • Predeploys/Genesis:
    • Replace TOKEN_MANAGER/ERC20/721 template and COLLECTIONS_MANAGER with FIXED_FUNGIBLE_HANDLER, FIXED_FUNGIBLE_TEMPLATE_IMPLEMENTATION, and COLLECTIONS_PROTOCOL_HANDLER.
    • Update L2Genesis.s.sol to set code and register fixed-fungible and new collections handler.
  • Ruby libs:
    • Replace TokenReader with FixedFungibleReader; switch addresses and event parsing in ProtocolEventReader; update SysConfig constants.
    • Simplify genesis.rake task.
  • Tests:
    • Update specs to use new handler/contracts, events, addresses, and extractor names; adjust protocol strings (fixed-fungible) where applicable.

Written by Cursor Bugbot for commit 83e4f49. This will update automatically on new commits. Configure here.

@RogerPodacter RogerPodacter requested a review from Copilot October 22, 2025 18:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a comprehensive rename from "token"/"TokenManager"/"erc-20" terminology to "fixed-fungible"/"FixedFungibleProtocolHandler"/"fixed-fungible" across the codebase. The changes reflect a protocol rename to better describe the underlying token mechanics.

Key Changes:

  • Renamed TokenManager contract to FixedFungibleProtocolHandler and updated all event names
  • Changed protocol identifier from "erc-20" to "fixed-fungible" throughout the codebase
  • Updated class names: TokenParamsExtractorFixedFungibleTokenParamsExtractor, TokenReaderFixedFungibleReader
  • Renamed ERC-20/ERC-721 template contracts and collections handler to align with new naming

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
spec/models/protocol_extractor_spec.rb Updated test expectations for protocol type and name changes
spec/models/generic_protocol_extractor_spec.rb Updated test context and extractor class references
spec/models/fixed_fungible_token_params_extractor_spec.rb Renamed spec file and updated all class references
spec/models/ethscription_transaction_builder_spec.rb Updated extractor class name and expected protocol values
spec/integration/tokens_protocol_spec.rb Updated reader class references and protocol expectations
spec/integration/token_protocol_e2e_spec.rb Updated event names, reader references, and comments
lib/tasks/genesis.rake Simplified task implementation
lib/sys_config.rb Renamed constant and accessor method
lib/protocol_event_reader.rb Updated event signatures and parser method names
lib/fixed_fungible_reader.rb Renamed class and updated protocol value
contracts/test/*.t.sol Updated contract references, constant names, and type names across all test files
contracts/src/libraries/Predeploys.sol Renamed predeploy constants and updated comments
contracts/src/FixedFungibleProtocolHandler.sol Renamed contract and updated event/constant names
contracts/src/FixedFungibleERC20.sol Renamed contract and updated access control references
contracts/src/CollectionsProtocolHandler.sol Renamed contract and template reference
contracts/src/CollectionsERC721.sol Updated manager class references
contracts/script/L2Genesis.s.sol Updated protocol registration and predeploy references
app/models/protocol_extractor.rb Updated extractor class references and protocol identifiers
app/models/generic_protocol_extractor.rb Updated helper method implementation
app/models/fixed_fungible_token_params_extractor.rb Renamed class and added protocol pattern matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread app/models/fixed_fungible_token_params_extractor.rb Outdated
cursor[bot]

This comment was marked as outdated.

@RogerPodacter RogerPodacter requested a review from Copilot October 22, 2025 19:00
@RogerPodacter RogerPodacter merged commit 5bea0d5 into evm-backend-demo Oct 22, 2025
2 checks passed
@RogerPodacter RogerPodacter deleted the rename branch October 22, 2025 19:08
@RogerPodacter RogerPodacter removed the request for review from Copilot March 23, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants