-
Notifications
You must be signed in to change notification settings - Fork 25
Add Multicall3 deployment and pagination support for Ethscriptions #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,6 +18,8 @@ library Predeploys { | |||||||
| /// @notice ProxyAdmin predeploy (manages all proxy upgrades) | ||||||||
| address constant PROXY_ADMIN = 0x4200000000000000000000000000000000000018; | ||||||||
|
|
||||||||
|
||||||||
| /// @notice Multicall3 predeploy (canonical multicall contract for batched calls) |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing NatSpec documentation for the MultiCall3Code constant. Add a comment explaining what this bytecode represents, such as: /// @notice Compiled bytecode for the Multicall3 contract deployment
| /// @notice Compiled bytecode for the Multicall3 contract deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing NatSpec documentation explaining why these specific page size limits were chosen. Consider adding comments that explain the rationale (e.g., gas limits, response size considerations) for these magic numbers.