Stricter ethd CI#2554
Open
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
Open
Conversation
yorickdowne
force-pushed
the
ethd-CI
branch
3 times, most recently
from
9a0e09b to
db2af26
Compare
yorickdowne
force-pushed
the
ethd-CI
branch
3 times, most recently
from
c938b2b to
9bca56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
expectfails when it doesn't see what it expects, on unexpected EOF, or when an expected EOF does not materialize./ethd config --ciskips the final build step, so CI finishes in a reasonable timePro: The CI actually tells us if the config flow is not as expected
Con: The CI needs to be adjusted every time the config flow changes
Alternative: Remove the entire expect CI. However, it's there for a reason: it's meant to find paths that have
ethdfail with an exit codeTwo small style changes