Invalidate build cache less often#2558
Draft
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
Draft
Conversation
yorickdowne
force-pushed
the
docker-build-cache
branch
7 times, most recently
from
dde7230 to
8f0be1c
Compare
yorickdowne
force-pushed
the
docker-build-cache
branch
from
8f0be1c to
5f94df5
Compare
Collaborator
Author
|
Putting this to draft. I'm worried it'll keep the build from pulling in changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Users that
./ethd updatefrequently get to keep their build cache, until 50GB are reclaimable. Strike a balance between cleaning up Docker artefacts and constantly rebuilding from scratch.Parsing the
docker system dfoutput is brittle. There are multiple safeguards in place to just return and do nothing, instead of failingethdentirely.