Document Web3signer default heap#2560
Open
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
Open
Conversation
yorickdowne
force-pushed
the
web3signer-heap
branch
from
941ea87 to
b5ceee9
Compare
yorickdowne
force-pushed
the
web3signer-heap
branch
from
a1caecb to
cc643bf
Compare
yorickdowne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
26.4.1fixes a memory leak on startupThis needs to be thoroughly tested. In draft until I can do so. Ethstaker has 15k Hoodi keys, that would be a good test.
After testing, no. With
-Xmx6gand 32 keys, Web3signer uses no more than 1.5 GiB during key load. With 15,000 keys, it uses up to 6.4 GiB during key load in 500-key batches, then drops down.High Xmx does not hurt users with few keys, and protects users with many keys.
Changed PR to merely correctly document the default