Better handling for a multi-user setup#2575
Open
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
Open
Better handling for a multi-user setup#2575yorickdowne wants to merge 1 commit intoethstaker:mainfrom
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
Conversation
c41d9ea to
1ff5413
Compare
2 tasks
6d9ed07 to
d0cdd6e
Compare
6feec78 to
ee46ee2
Compare
ee46ee2 to
b428c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Improve the use case where
node:node-adminsowns the directory, andaliceandbobare members ofnode-adminscpfor created files becomesinstall, because I couldn't figure out how to be graceful otherwise when the user has group write permissions but forgot setgidThe base case of owner
alice:aliceand useralicehas not been impacted. That's quite important, and if review finds that's not so, that needs to be fixed.There are corner cases where
bob, if they don't have sudo andothercan't read on the directory, needsalice, who does havesudo, to runethdat least once first, so config files are created and given the right permissions.There is a test script at
tests/test-multiuser.shthat runs through a number of scenarios and checks ownership and permissions. That includes runningethdasrootand verifying that file ownership does not becomeroot.It's entirely plausible I missed a corner case. Careful review requested.
Also resolves #2570