Skip to content

Better handling for a multi-user setup#2575

Open
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
yorickdowne:better-multiuser
Open

Better handling for a multi-user setup#2575
yorickdowne wants to merge 1 commit intoethstaker:mainfrom
yorickdowne:better-multiuser

Conversation

@yorickdowne
Copy link
Copy Markdown
Collaborator

@yorickdowne yorickdowne commented Apr 26, 2026

What I did

Improve the use case where node:node-admins owns the directory, and alice and bob are members of node-admins

cp for created files becomes install, because I couldn't figure out how to be graceful otherwise when the user has group write permissions but forgot setgid

The base case of owner alice:alice and user alice has not been impacted. That's quite important, and if review finds that's not so, that needs to be fixed.

There are corner cases where bob, if they don't have sudo and other can't read on the directory, needs alice, who does have sudo, to run ethd at least once first, so config files are created and given the right permissions.

There is a test script at tests/test-multiuser.sh that runs through a number of scenarios and checks ownership and permissions. That includes running ethd as root and verifying that file ownership does not become root.

It's entirely plausible I missed a corner case. Careful review requested.

Also resolves #2570

@yorickdowne yorickdowne marked this pull request as draft April 26, 2026 07:24
@yorickdowne yorickdowne force-pushed the better-multiuser branch 3 times, most recently from c41d9ea to 1ff5413 Compare April 26, 2026 07:57
@yorickdowne yorickdowne force-pushed the better-multiuser branch 10 times, most recently from 6d9ed07 to d0cdd6e Compare April 27, 2026 21:31
@yorickdowne yorickdowne marked this pull request as ready for review April 27, 2026 21:32
@yorickdowne yorickdowne requested a review from pietjepuk2 April 27, 2026 21:35
@yorickdowne yorickdowne force-pushed the better-multiuser branch 3 times, most recently from 6feec78 to ee46ee2 Compare April 27, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious ownership fix on every start when directory group differs from owner's primary group

1 participant