Do not track minimum version for history expiry#2680
Open
yorickdowne wants to merge 1 commit into
Open
Conversation
yorickdowne
changed the title
Collaborator
Author
|
In draft until Nimbus Unified has been merged |
yorickdowne
force-pushed
the
no-history-minver
branch
from
3de0c9d to
52cce45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Informing users of a minimum EL version for history expiry was useful when pre-merge expiry was new and not all clients had it.
It is no longer useful. Client minimum version is driven by hard forks and to a lesser extent Eth Docker version