Skip to content

Commit 1b7b73d

Browse files
authored
rename isSubmitting override (#98)
1 parent 3baec44 commit 1b7b73d

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

components/form.tsx

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -257,26 +257,26 @@ const submitLabelKnownMappings: Record<string, SubmitLabelMapping> = {
257257
interface SubmitProps extends ButtonProps {
258258
label: string | SubmitLabelMapping;
259259
skipDirtyCheck?: boolean;
260-
isSubmitting?: boolean;
260+
forceLoading?: boolean;
261261
submittingLabel?: string;
262262
successLabel?: string;
263263
}
264264

265265
function Submit({
266266
skipDirtyCheck = false,
267267
label = submitLabelKnownMappings.save,
268-
isSubmitting: isSubmittingOverride = false,
268+
forceLoading,
269269
...rest
270270
}: SubmitProps) {
271271
const {
272-
formState: { isValid, isDirty, isSubmitting, isSubmitSuccessful },
272+
formState: { isValid, isDirty, isSubmitSuccessful, isSubmitting },
273273
} = useFormContext();
274274

275-
const isSubmittingWithOverride = isSubmittingOverride || isSubmitting;
275+
const isLoading = isSubmitting || forceLoading;
276276

277277
const disabled = skipDirtyCheck
278-
? !isValid || isSubmittingWithOverride
279-
: !isDirty || !isValid || isSubmittingWithOverride;
278+
? !isValid || isLoading
279+
: !isDirty || !isValid || isLoading;
280280

281281
const labelMapping =
282282
typeof label === "string"
@@ -287,7 +287,7 @@ function Submit({
287287
if (!labelMapping) {
288288
// at this point it can only be a string
289289
computedLabel = label as string;
290-
} else if (isSubmittingWithOverride) {
290+
} else if (isLoading) {
291291
computedLabel = labelMapping.saving;
292292
} else if (isSubmitSuccessful) {
293293
computedLabel = labelMapping.saved;
@@ -296,7 +296,7 @@ function Submit({
296296
}
297297

298298
let icon: LucideIcon;
299-
if (isSubmittingWithOverride) {
299+
if (isLoading) {
300300
icon = LoaderCircle;
301301
} else if (isDirty) {
302302
icon = Save;
@@ -305,9 +305,7 @@ function Submit({
305305
} else {
306306
icon = Save;
307307
}
308-
const iconProps = isSubmittingWithOverride
309-
? { className: "animate-spin" }
310-
: {};
308+
const iconProps = isLoading ? { className: "animate-spin" } : {};
311309

312310
return (
313311
<Button type="submit" disabled={disabled} {...rest}>

0 commit comments

Comments
 (0)