Skip to content

Feature/backup lqoc man ex#131

Draft
markusgft wants to merge 28 commits into
v3.0.3-develfrom
feature/backup_lqoc_man_ex
Draft

Feature/backup lqoc man ex#131
markusgft wants to merge 28 commits into
v3.0.3-develfrom
feature/backup_lqoc_man_ex

Conversation

@markusgft

Copy link
Copy Markdown
Member

No description provided.

t_perturbed = m_log;
t_perturbed.coeffs()(i) = mlog_ph;
t_perturbed.set_coeff(i, mlog_ph); // TODO
//t_perturbed.coeffs()(i) = mlog_ph;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be solved cleanly, most likely requires a change in manif.

sv_[k]/*.noalias()*/ += p.A_[k].transpose() * S_[k + 1] * p.b_[k];
sv_[k]/*.noalias()*/ += this->L_[k].transpose() * Hi_[k] * this->lv_[k];
sv_[k]/*.noalias()*/ += this->L_[k].transpose() * gv_[k];
sv_[k]/*.noalias()*/ += G_[k].transpose() * this->lv_[k]; // TODO: bring back all the noalias()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the noalias() must be fixed properly, maybe requires changing manif.

template <int STATE_DIM, int CONTROL_DIM>
const ct::core::ControlVectorArray<CONTROL_DIM>& HPIPMInterface<STATE_DIM, CONTROL_DIM>::get_lv()
template <typename MANIFOLD, int CONTROL_DIM>
const ct::core::ControlVectorArray<CONTROL_DIM>& HPIPMInterface<MANIFOLD, CONTROL_DIM>::get_lv()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: throw an error at compile time if HPIPM is attempted to be built with a non-euclidean manifold

Comment thread ct_optcon/test/CMakeLists.txt Outdated
package_add_test(system_interface_test system_interface/SystemInterfaceTest.cpp)
#package_add_test(system_interface_test system_interface/SystemInterfaceTest.cpp)

#add_executable(KinematicManifoldLQOCTest solver/linear/KinematicManifoldLQOCTest.cpp)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove those executables from the cmakelist and make them proper unit tests

# package_add_test(constraint_test constraint/ConstraintTest.cpp)
package_add_test(CostFunctionTests costfunction/CostFunctionTests.cpp)
package_add_test(LoadFromFileTest costfunction/LoadFromFileTest.cpp)
# package_add_test(CostFunctionTests costfunction/CostFunctionTests.cpp)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring back those tests

@@ -0,0 +1,514 @@

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstract the composite manifold classes, move them to an appropriate place

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check back on the latest developments within manif regarding composite manifolds.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extend the generic NLOC classes with the novel features and make this a unit test which compares them against the solution below.

@markusgft
markusgft marked this pull request as draft October 6, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants