Skip to content

Cmake fix#689

Merged
kottnad merged 3 commits into
masterfrom
cmake_fix
May 19, 2026
Merged

Cmake fix#689
kottnad merged 3 commits into
masterfrom
cmake_fix

Conversation

@mtaillefumier
Copy link
Copy Markdown
Contributor

@mtaillefumier mtaillefumier commented Apr 20, 2026

@mtaillefumier mtaillefumier requested a review from kostrzewa May 18, 2026 08:19
@mtaillefumier
Copy link
Copy Markdown
Contributor Author

@chaoos : I would appreciate your feedback on this PR. It needs to be merged soonish as it fixes few issues with include directories.

@kostrzewa
Copy link
Copy Markdown
Member

@kottnad could you please review this and merge?

@kostrzewa kostrzewa requested review from kottnad and removed request for kostrzewa May 18, 2026 08:54
@chaoos
Copy link
Copy Markdown
Contributor

chaoos commented May 18, 2026

@mtaillefumier Looks good to me.

Only small concern I have is that you changed multiple check_cxx_source_compiles into check_source_runs. That might lead to problems when not building on a target node. This is no problem on daint, but maybe on another cluster. Is there a possibility to bypass the SIMD detection and provide values explicitely?

@mtaillefumier
Copy link
Copy Markdown
Contributor Author

mtaillefumier commented May 18, 2026

True. I just do not know how to check which instruction is effectively supported during compile time without running it after compilation. check_cxx_source_compiles only checks that the code compiles not that the instruction is supported on the machine at runtime, that's why my initial implementation was defective in practice.

The best solution would be to check if the instruction set is supported at compilation time without running the executable but I am not sure if it is possible in practice.

Is there any case of cross-compilation ?

@chaoos
Copy link
Copy Markdown
Contributor

chaoos commented May 18, 2026

I understand, please go on. We can think about adding a bypass when the problem arises. For me this can be merged, thanks for the changes! 👍

@kottnad kottnad merged commit 10d4fce into master May 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants