Conversation
811c611 to
42b590b
Compare
|
@chaoos : I would appreciate your feedback on this PR. It needs to be merged soonish as it fixes few issues with include directories. |
|
@kottnad could you please review this and merge? |
|
@mtaillefumier Looks good to me. Only small concern I have is that you changed multiple |
|
True. I just do not know how to check which instruction is effectively supported during compile time without running it after compilation. The best solution would be to check if the instruction set is supported at compilation time without running the executable but I am not sure if it is possible in practice. Is there any case of cross-compilation ? |
|
I understand, please go on. We can think about adding a bypass when the problem arises. For me this can be merged, thanks for the changes! 👍 |
Uh oh!
There was an error while loading. Please reload this page.