Skip to content

Commit 563f86d

Browse files
etrclaude
andcommitted
TASK-077: mark Done in M7 milestone index and persist 27 unworked review findings
Flip TASK-077 status to Done in TASK-077.md and _index.md, check off the five action items, and log the 27 minor findings (0 critical, 0 major) surfaced by the validation loop for future cleanup sweeps. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 317e71d commit 563f86d

3 files changed

Lines changed: 122 additions & 7 deletions

File tree

specs/tasks/M7-v2-cleanup/TASK-077.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ Three whole-suite or near-whole-suite skips remove the library's portability cla
1414
Either land Windows/Darwin variants or document and gate the exclusion behind a CI flag that asserts intent rather than letting silent skips drift.
1515

1616
**Action Items:**
17-
- [ ] For `threaded.cpp`: write a Windows-shaped variant of the suite (matching the I/O completion port semantics MHD uses on Windows) under `#ifdef _WINDOWS`, or document why no Windows variant is feasible and capture the gap in `test/PORTABILITY.md`.
18-
- [ ] For `ws_start_stop.cpp` Windows skip: same — variant suite under `#ifdef _WINDOWS`, or PORTABILITY.md note. Comment must explain *why* MHD's Windows path can't drive this scenario.
19-
- [ ] For the postponed digest-auth Windows tests in `ws_start_stop.cpp:176-180` and `authentication.cpp:176-180`: either port them or document the upstream MHD-on-Windows limitation. If coordinated with TASK-062 (Digest RFC-7616), bring up there.
20-
- [ ] For `ws_start_stop.cpp:337` `custom_socket` Darwin skip: add a comment naming the macOS-specific limitation, or port. Comment must reference the specific Darwin syscall behaviour that fails.
21-
- [ ] Add a `scripts/check-skip-rationales.sh` lint that fails CI if a `#ifndef _WINDOWS` or `#ifndef DARWIN` block in `test/integ/` lacks a `// reason:` comment.
17+
- [x] For `threaded.cpp`: write a Windows-shaped variant of the suite (matching the I/O completion port semantics MHD uses on Windows) under `#ifdef _WINDOWS`, or document why no Windows variant is feasible and capture the gap in `test/PORTABILITY.md`.
18+
- [x] For `ws_start_stop.cpp` Windows skip: same — variant suite under `#ifdef _WINDOWS`, or PORTABILITY.md note. Comment must explain *why* MHD's Windows path can't drive this scenario.
19+
- [x] For the postponed digest-auth Windows tests in `ws_start_stop.cpp:176-180` and `authentication.cpp:176-180`: either port them or document the upstream MHD-on-Windows limitation. If coordinated with TASK-062 (Digest RFC-7616), bring up there.
20+
- [x] For `ws_start_stop.cpp:337` `custom_socket` Darwin skip: add a comment naming the macOS-specific limitation, or port. Comment must reference the specific Darwin syscall behaviour that fails.
21+
- [x] Add a `scripts/check-skip-rationales.sh` lint that fails CI if a `#ifndef _WINDOWS` or `#ifndef DARWIN` block in `test/integ/` lacks a `// reason:` comment.
2222

2323
**Dependencies:**
2424
- Blocked by: None
@@ -34,4 +34,4 @@ Either land Windows/Darwin variants or document and gate the exclusion behind a
3434
**Related Requirements:** PRD §2 portability NFR
3535
**Related Decisions:** None new
3636

37-
**Status:** Backlog
37+
**Status:** Done

specs/tasks/M7-v2-cleanup/_index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ TASK-093).
4141
| TASK-074 | Gate DEBUG raw-body printing behind explicit opt-in | LOW (sec) | S | Done |
4242
| TASK-075 | Propagate `wait_for_server_ready` to sibling hooks integ tests | HIGH | M | Done |
4343
| TASK-076 | Replace tautological-pass blocks in TLS test lanes | HIGH | M | Done |
44-
| TASK-077 | Restore Windows / Darwin coverage in skipped test suites | HIGH | L | Backlog |
44+
| TASK-077 | Restore Windows / Darwin coverage in skipped test suites | HIGH | L | Done |
4545
| TASK-078 | Resolve commented-out CONNECT-method test bodies | HIGH | S | Backlog |
4646
| TASK-079 | Drive nonce/opaque state machine in v2 digest-auth integ tests | MED | M | Backlog |
4747
| TASK-080 | Tighten threadsafety_stress latency gate back from 100× to 10× | MED | M | Backlog |

0 commit comments

Comments
 (0)