Merge TASK-071: wire install_not_found_alias_ and remove dead lambda_handler variant arm

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: etr

specs/architecture/04-components/route-table.md

@@ -10,7 +10,7 @@
 
 A `route_entry` carries:
 - `method_set methods` — which methods this entry serves
-- `std::variant<lambda_handler, std::shared_ptr<http_resource>>` — the actual handler (lambda or class)
+- `std::shared_ptr<http_resource>` — the actual handler; always a class-derived `http_resource` or a `lambda_resource` shim (the `lambda_handler` variant arm was removed in TASK-071; every lambda path already went through `lambda_resource`, so no call-site behaviour changed)
 - `bool is_prefix` — radix node bookkeeping
 
 **Cache:** an LRU cache (256 entries) sits in front of all three structures, keyed by full path (and method, for per-method-handler entries). After warm-up, hot paths bypass even the hash lookup.
@@ -27,6 +27,6 @@ A `route_entry` carries:
 
 **Related requirements:** PRD-HDL-REQ-002, PRD-HDL-REQ-004, PRD-HDL-REQ-006.
 
-**Implementation status:** TASK-025 introduced `detail::route_entry` and the `lambda_resource` shim into the existing v1 three-map storage shape. TASK-027 wired `route_entry` into the full 3-tier table described above (hash map for exact paths, radix tree for parameterized/prefix paths, regex chain for regex routes). TASK-053 retired the v1 dispatch path: `webserver_impl::resolve_resource_for_request` now consults `lookup_v2()` (cache → exact → radix → regex) directly, the v1 LRU cache and the four v1 lookup helpers (`lookup_route_cache`, `scan_regex_routes`, `store_route_cache`, `apply_extracted_params`) are deleted, and the LRU cache field is renamed `route_lru_cache`. **TASK-067** deleted the v1 registration-side maps (`registered_resources`, `registered_resources_str`, `registered_resources_regex`) and their shared mutex; the v2 3-tier table is now the only routing surface end-to-end. Lambda/class path-conflict detection (`prepare_or_create_lambda_shim`) probes the v2 tiers via `find_v2_entry_by_path_`; the WebSocket registration map keeps its own `registered_ws_handlers_mutex_`. TASK-056 swapped the radix-node child container from `std::unordered_map` to `std::map<…, std::less<>>` for CWE-407 immunity and added registration-time detection of prefix-vs-exact terminus collisions (`reject_terminus_collision`).
+**Implementation status:** TASK-025 introduced `detail::route_entry` and the `lambda_resource` shim into the existing v1 three-map storage shape. TASK-027 wired `route_entry` into the full 3-tier table described above (hash map for exact paths, radix tree for parameterized/prefix paths, regex chain for regex routes). TASK-053 retired the v1 dispatch path: `webserver_impl::resolve_resource_for_request` now consults `lookup_v2()` (cache → exact → radix → regex) directly, the v1 LRU cache and the four v1 lookup helpers (`lookup_route_cache`, `scan_regex_routes`, `store_route_cache`, `apply_extracted_params`) are deleted, and the LRU cache field is renamed `route_lru_cache`. **TASK-067** deleted the v1 registration-side maps (`registered_resources`, `registered_resources_str`, `registered_resources_regex`) and their shared mutex; the v2 3-tier table is now the only routing surface end-to-end. Lambda/class path-conflict detection (`prepare_or_create_lambda_shim`) probes the v2 tiers via `find_v2_entry_by_path_`; the WebSocket registration map keeps its own `registered_ws_handlers_mutex_`. TASK-056 swapped the radix-node child container from `std::unordered_map` to `std::map<…, std::less<>>` for CWE-407 immunity and added registration-time detection of prefix-vs-exact terminus collisions (`reject_terminus_collision`). **TASK-071** collapsed `route_entry::handler` from `std::variant<lambda_handler, std::shared_ptr<http_resource>>` to a bare `std::shared_ptr<http_resource>`; the `lambda_handler` variant arm was dead (every writer already went through the `lambda_resource` shim), so removing it simplified dispatch without changing any observable behaviour.
 
 ---

specs/tasks/M7-v2-cleanup/TASK-071.md

@@ -10,10 +10,10 @@ Two related forward-debt items in the alias/dispatch plumbing:
 2. `src/detail/webserver_dispatch.cpp:260, 313-318` — dead `lambda_handler` variant arm kept "for a future task" that may store lambdas directly. Either land the lambda-storage path or remove the dead arm.
 
 **Action Items:**
-- [ ] In `install_not_found_alias_`, replace the empty stub callback with the real `route_resolved`-phase hook that builds the 404 response matching v1 behaviour, mirroring the structure of `install_method_not_allowed_alias_` and `install_internal_error_alias_`.
-- [ ] Add an integ test covering the alias path end-to-end (request a missing route, expect 404 with the alias-built body).
-- [ ] In `webserver_dispatch.cpp:260, 313-318`: decide whether the `lambda_handler` variant arm is needed. If yes, land the lambda-storage path so the arm is exercised. If no, remove the arm and update the variant's `std::variant` parameter list.
-- [ ] Update Doxygen on `webserver::route(...)` if the variant shape changed.
+- [x] In `install_not_found_alias_`, replace the empty stub callback with the real `route_resolved`-phase hook that builds the 404 response matching v1 behaviour, mirroring the structure of `install_method_not_allowed_alias_` and `install_internal_error_alias_`.
+- [x] Add an integ test covering the alias path end-to-end (request a missing route, expect 404 with the alias-built body).
+- [x] In `webserver_dispatch.cpp:260, 313-318`: decide whether the `lambda_handler` variant arm is needed. If yes, land the lambda-storage path so the arm is exercised. If no, remove the arm and update the variant's `std::variant` parameter list.
+- [x] Update Doxygen on `webserver::route(...)` if the variant shape changed (no public Doxygen referenced the variant; internal code comments updated in route_entry.hpp).
 
 **Dependencies:**
 - Blocked by: TASK-048 (route_resolved/before_handler firing, Done)
@@ -28,4 +28,4 @@ Two related forward-debt items in the alias/dispatch plumbing:
 **Related Requirements:** PRD-HOOK-REQ-009 (v1 setters as aliases)
 **Related Decisions:** DR-012
 
-**Status:** Backlog
+**Status:** Done

specs/tasks/M7-v2-cleanup/_index.md

@@ -35,7 +35,7 @@ TASK-093).
 | TASK-068 | `connection_state` hardening — CWE-226 / CWE-14 | MED | S | Done |
 | TASK-069 | Remove transitional two-arg `http_request_impl` constructor | MED | S | Done |
 | TASK-070 | Migrate `hook_table_` to `std::atomic<std::shared_ptr<T>>` | MED | M | Backlog |
-| TASK-071 | Wire `install_not_found_alias_` stub and remove dead `lambda_handler` arm | MED | S | Backlog |
+| TASK-071 | Wire `install_not_found_alias_` stub and remove dead `lambda_handler` arm | MED | S | Done |
 | TASK-072 | Arena-allocated unescape on the warm path | MED | M | Backlog |
 | TASK-073 | Revisit libmicrohttpd v0.99 unescape workaround | LOW | S | Backlog |
 | TASK-074 | Gate DEBUG raw-body printing behind explicit opt-in | LOW (sec) | S | Backlog |