Skip to content

Add support for async generator injections#900

Merged
ZipFile merged 3 commits into
developfrom
fix/async-gen-injects
Jun 3, 2025
Merged

Add support for async generator injections#900
ZipFile merged 3 commits into
developfrom
fix/async-gen-injects

Conversation

@ZipFile

@ZipFile ZipFile commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Fixes #603 and #745.

_cwiring.pyx got major overhaul, but otherwise behavior and performance should stay the same.

This was linked to issues Jun 2, 2025
Injecting an async resource into an async generator provides future instead of resource #603
Closed
The library can't handle async generators #745
Closed
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/wiring.py Outdated
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/wiring.py Outdated
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/wiring.py Outdated
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/wiring.py Outdated
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/wiring.py Outdated
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/wiring.py Outdated
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/_cwiring.pyx
rmk135
rmk135 reviewed Jun 3, 2025
View reviewed changes
Comment thread src/dependency_injector/_cwiring.pyx Outdated
@rmk135

rmk135 commented Jun 3, 2025

Copy link
Copy Markdown
Member

@ZipFile That's a fantastic improvement! Thank you for doing this!

@ZipFile ZipFile merged commit d8e49f7 into develop Jun 3, 2025
24 checks passed
@ZipFile ZipFile deleted the fix/async-gen-injects branch June 3, 2025 18:45
@coveralls

coveralls commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 94.672% (+0.1%) from 94.557%
when pulling e55d11e on fix/async-gen-injects
into c1f14a8 on develop.

This was linked to issues Jun 3, 2025
Ressource not closed in case of Exception in the function #681
Closed
@inject decorator on a FastAPI dependency with yield #671
Closed
FastAPI async resouce not being closed #595
Closed
Async resource is sometimes None #539
Closed
@ZipFile ZipFile linked an issue Jun 16, 2025 that may be closed by this pull request
Singleton provider throws RuntimeError: Task got bad yield for generators #795
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment