Redesign of Parser and Render#11
Open
brunomp wants to merge 12 commits into
Open
Conversation
Owner
|
Ok for me, just fix unit test :) |
Owner
|
@brunomp any news ? |
1 similar comment
Owner
|
@brunomp any news ? |
endelwar
reviewed
Jun 10, 2019
| @@ -1,14 +1,18 @@ | |||
| { | |||
| "name": "euskadi31/Opengraph", | |||
| "name": "brunomp/opengraph", | |||
endelwar
reviewed
Jun 10, 2019
| case self::OG_IMAGE_URL: | ||
|
|
||
| $data = array( | ||
| $property . ':url' => $content |
There was a problem hiding this comment.
self::OG_IMAGE needs ':url' suffix to be added
Owner
|
@brunomp any news ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parser replaced the class Reader and Render replaced the class Writer. It is now possible to render Opengraph in Json and restore it with ParserJson. The new design allows new Parser types and new Render types to be created without the need to change the Opengraph class (Open-closed principle of SOLID).