fix: replace alert() with inline hints for notification permission feedback

- Replace blocking alert() dialogs with inline hint text below the
  Desktop Notifications toggle in settings
- Show hint on settings page init when permission is denied/unsupported
- Add clarifying comment for retryOn: [500] meaning all 5xx errors

Author: euxx

src/lib/github-api.js

@@ -87,7 +87,8 @@ async function retryWithStrategy(fetchFn, options = {}) {
           return response;
         }
 
-        // Check if we should retry this status code
+        // Check if we should retry this status code.
+        // Note: including 500 in retryOn acts as a wildcard for all 5xx errors.
         const shouldRetry =
           retryOn.includes(response.status) || (response.status >= 500 && retryOn.includes(500));
 

src/popup/popup.css

@@ -1454,6 +1454,7 @@ body.dark-theme .settings-view {
 
 .setting-hint {
   margin-top: 4px;
+  padding-left: 40px;
   font-size: 11px;
   color: var(--text-secondary);
   line-height: 1.4;

src/popup/popup.html

@@ -322,6 +322,7 @@ <h3 class="settings-title">Settings</h3>
               <span class="toggle-slider" aria-hidden="true"></span>
             </label>
           </div>
+          <div id="desktop-notifications-hint" class="setting-hint" hidden aria-live="polite"></div>
 
           <div class="setting-row">
             <span class="setting-icon" aria-hidden="true">

src/popup/popup.js

@@ -197,6 +197,7 @@ const hoverCardsToggle = document.getElementById("hover-cards-toggle");
 
 // Desktop notification settings
 const desktopNotificationsToggle = document.getElementById("desktop-notifications-toggle");
+const desktopNotificationsHint = document.getElementById("desktop-notifications-hint");
 
 let scrollbarCompensationRaf = null;
 
@@ -440,9 +441,18 @@ async function showSettings() {
     desktopNotificationsToggle.disabled = true;
     desktopNotificationsToggle.parentElement.title =
       "Browser notification permission denied. Please enable it in browser settings.";
+    if (desktopNotificationsHint) {
+      desktopNotificationsHint.textContent =
+        "Permission denied. Please enable notifications in browser settings.";
+      desktopNotificationsHint.hidden = false;
+    }
   } else if (permission === "unsupported") {
     desktopNotificationsToggle.disabled = true;
     desktopNotificationsToggle.parentElement.title = "Browser notifications not supported.";
+    if (desktopNotificationsHint) {
+      desktopNotificationsHint.textContent = "Browser notifications are not supported.";
+      desktopNotificationsHint.hidden = false;
+    }
   }
   // Hide header and footer
   document.querySelector(".header").hidden = true;
@@ -1011,6 +1021,8 @@ hoverCardsToggle.addEventListener("change", async () => {
 desktopNotificationsToggle.addEventListener("change", async () => {
   const enabled = desktopNotificationsToggle.checked;
 
+  if (desktopNotificationsHint) desktopNotificationsHint.hidden = true;
+
   if (enabled) {
     // Check current permission
     let permission = checkNotificationPermission();
@@ -1028,12 +1040,14 @@ desktopNotificationsToggle.addEventListener("change", async () => {
       desktopNotificationsToggle.checked = false;
       await storage.setEnableDesktopNotifications(false);
 
-      if (permission === "denied") {
-        alert(
-          "Browser notification permission was denied. Please enable it in your browser settings to use desktop notifications.",
-        );
-      } else if (permission === "unsupported") {
-        alert("Browser notifications are not supported in this browser.");
+      if (desktopNotificationsHint) {
+        if (permission === "denied") {
+          desktopNotificationsHint.textContent =
+            "Permission denied. Please enable notifications in browser settings.";
+        } else if (permission === "unsupported") {
+          desktopNotificationsHint.textContent = "Browser notifications are not supported.";
+        }
+        desktopNotificationsHint.hidden = false;
       }
     }
   } else {