Skip to content

Commit 3adac79

Browse files
committed
fix: resolve lint errors from ESLint upgrade
- github-api.js: attach cause to re-thrown timeout error (preserve-caught-error) - popup.js: remove useless initial value on `message` declaration - popup.js: remove redundant `className` reassignment in else branch (no-useless-assignment)
1 parent 04df2ee commit 3adac79

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/lib/github-api.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ async function fetchWithTimeout(url, options = {}, timeout = API_TIMEOUTS.DEFAUL
4646
return response;
4747
} catch (error) {
4848
if (error.name === 'AbortError') {
49-
throw new Error('Request timeout');
49+
throw new Error('Request timeout', { cause: error });
5050
}
5151
throw error;
5252
} finally {

src/popup/popup.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ async function refresh() {
618618
const cachedNotifications = await storage.getNotifications();
619619
renderNotifications(cachedNotifications, true); // Re-sort even on error
620620

621-
let message = '';
621+
let message;
622622
let className = 'error-message';
623623

624624
if (!navigator.onLine || error.message?.includes('NetworkError') || error.message?.includes('Failed to fetch')) {
@@ -632,7 +632,6 @@ async function refresh() {
632632
className = 'warning-message';
633633
} else {
634634
message = `❌ Error: ${error.message || 'Failed to refresh'}`;
635-
className = 'error-message';
636635
}
637636

638637
// Show error/warning message

0 commit comments

Comments
 (0)