clean up

Author: ev-br

array_api_strict/_array_object.py

@@ -45,8 +45,6 @@
 from ._typing import PyCapsule
 
 
-
-
 class Array:
     """
     n-d array object for the array API namespace.

array_api_strict/_creation_functions.py

@@ -27,7 +27,6 @@ class Undef(Enum):
 
 def _check_valid_dtype(dtype: DType | None, device: Device | None = None) -> None:
     # Note: Only spelling dtypes as the dtype objects is supported.
-
     if dtype is not None:
         if dtype not in _all_dtypes:
             raise ValueError(f"dtype must be one of the supported dtypes, got {dtype!r}")
@@ -37,11 +36,9 @@ def _check_valid_dtype(dtype: DType | None, device: Device | None = None) -> Non
                 raise ValueError(f"Device {device!r} does not support dtype={dtype!r}.")
         return dtype
     else:
-        # if dtype=None, return the default for the device
+        # TODO if dtype=None, return the default for the device
         _device = CPU_DEVICE if device is None else device
-        
-        return 
-
+        return dtype    # FIXME
 
 def _supports_buffer_protocol(obj: object) -> TypeIs[SupportsBufferProtocol]:
     try:

array_api_strict/_devices.py

@@ -2,7 +2,6 @@
 
 from ._dtypes import DType, float64, complex128
 from ._dtypes import (
-#    _kind_to_dtypes,
     _all_dtypes, _boolean_dtypes, _signed_integer_dtypes,
     _unsigned_integer_dtypes, _integer_dtypes, _real_floating_dtypes,
     _complex_floating_dtypes, _numeric_dtypes
@@ -94,7 +93,6 @@ def _map_helper(dtypes: list[DType], device: Device) -> dict[str, DType]:
         }
     _device_dtype_maps[device] = _map
 
-###breakpoint()
 
 
 '''

array_api_strict/_dtypes.py

@@ -141,48 +141,6 @@ def _np_dtype(dtype: DType | None) -> np.dtype[Any] | None:
 
 _real_to_complex_map = {float32: complex64, float64: complex128}
 
-
-
-
-'''
-_kind_to_dtypes = {
-    None: {x._canonic_name:x for x in _all_dtypes},
-    "bool": {"bool": bool},
-    "signed integer": {x._canonic_name: x for x in _signed_integer_dtypes},
-    "unsigned integer": {x._canonic_name: x for x in _unsigned_integer_dtypes},
-    "integral": {x._canonic_name: x for x in _integer_dtypes},
-    "real floating": {x._canonic_name: x for x in _real_floating_dtypes},
-    "complex floating": {x._canonic_name: x for x in _complex_floating_dtypes},
-    "numeric": {x._canonic_name: x for x in _numeric_dtypes}
-}
-'''
-
-'''
-def _kind_to_dtypes(kind : str | None = None) -> dict[str, ...]:
-    """A helper for Device / _info.dtypes().
-
-    The `kind`s here are those _info.dtypes() accepts. Which differs from
-    "categories" above, yes.
-    """
-    if kind is None:
-        return {x._canonic_name:x for x in dt._all_dtypes}
-    if kind == "bool":
-        return {"bool": dt.bool}
-    if kind == "signed integer":
-        return {x._canonic_name: x for x in dt._signed_integer_dtypes}
-    if kind == "unsigned integer":
-        return {x._canonic_name: x for x in dt._unsigned_integer_dtypes}
-    if kind == "integral":
-        return {x._canonic_name: x for x in dt._integer_dtypes}
-    if kind == "real floating":
-        return {x._canonic_name: x for x in dt._real_floating_dtypes}
-    if kind == "complex floating":
-        return {x._canonic_name: x for x in dt._complex_floating_dtypes}
-    if kind == "numeric":
-        return {x._canonic_name: x for x in dt._numeric_dtypes}
-    raise ValueError(f"unsupported kind: {kind!r}")
-'''
-
 # Note: the spec defines a restricted type promotion table compared to NumPy.
 # In particular, cross-kind promotions like integer + float or boolean +
 # integer are not allowed, even for functions that accept both kinds.

array_api_strict/_info.py

@@ -50,7 +50,6 @@ def default_dtypes(
 
     @requires_api_version('2023.12')
     def dtypes(
-
         self,
         *,
         device: Device | None = None,