Skip to content

Commit 722d3d2

Browse files
committed
don't allow dataset id and dataset jsonl
1 parent 17896a7 commit 722d3d2

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

eval_protocol/cli_commands/create_rft.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ def _resolve_evaluator(
366366
def _resolve_dataset(
367367
project_root: str,
368368
account_id: str,
369-
evaluator_id: str,
370369
args: argparse.Namespace,
371370
selected_test_file_path: Optional[str],
372371
selected_test_func_name: Optional[str],
@@ -380,9 +379,15 @@ def _resolve_dataset(
380379
"""
381380
dataset_id = getattr(args, "dataset", None)
382381
dataset_jsonl = getattr(args, "dataset_jsonl", None)
383-
dataset_display_name = getattr(args, "dataset_display_name", None)
384382
dataset_resource_override: Optional[str] = None
385383

384+
if dataset_id and dataset_jsonl:
385+
print(
386+
"Error: --dataset and --dataset-jsonl cannot be used together.\n"
387+
" Use --dataset to reference an existing dataset, or --dataset-jsonl to create a new one from JSONL."
388+
)
389+
return None, None, None
390+
386391
if isinstance(dataset_id, str) and dataset_id.startswith("accounts/"):
387392
# Caller passed a fully-qualified dataset; capture it for body and keep only terminal id for printing
388393
dataset_resource_override = dataset_id
@@ -765,7 +770,6 @@ def create_rft_command(args) -> int:
765770
dataset_id, dataset_resource, dataset_jsonl = _resolve_dataset(
766771
project_root=project_root,
767772
account_id=account_id,
768-
evaluator_id=evaluator_id,
769773
args=args,
770774
selected_test_file_path=selected_test_file_path,
771775
selected_test_func_name=selected_test_func_name,

0 commit comments

Comments
 (0)