Skip to content

Commit 86a0cc4

Browse files
committed
update to new protobuf
1 parent 2b765e0 commit 86a0cc4

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

eval_protocol/cli_commands/create_rft.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,8 @@ def _create_rft_job(
660660
("temperature", "temperature"),
661661
("topP", "top_p"),
662662
("topK", "top_k"),
663-
("maxTokens", "max_output_tokens"),
664-
("n", "response_candidates_count"),
663+
("maxOutputTokens", "max_output_tokens"),
664+
("responseCandidatesCount", "response_candidates_count"),
665665
]:
666666
val = getattr(args, arg_name, None)
667667
if val is not None:

tests/test_cli_create_rft.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,8 @@ def _fake_validate_evaluator_locally(
182182
assert abs(ip["temperature"] - 0.9) < 1e-12
183183
assert abs(ip["topP"] - 0.95) < 1e-12
184184
assert ip["topK"] == 50
185-
assert ip["maxTokens"] == 4096
186-
assert ip["n"] == 6
185+
assert ip["maxOutputTokens"] == 4096
186+
assert ip["responseCandidatesCount"] == 6
187187
assert ip["extraBody"] == '{"foo":"bar"}'
188188

189189
# W&B mapping
@@ -1126,8 +1126,8 @@ def _fake_post(url, json=None, headers=None, timeout=None):
11261126

11271127
# Inference params mapping
11281128
ip = body["inferenceParameters"]
1129-
assert ip["n"] == 4
1130-
assert ip["maxTokens"] == 32768
1129+
assert ip["responseCandidatesCount"] == 4
1130+
assert ip["maxOutputTokens"] == 32768
11311131

11321132
# Other top-level
11331133
assert body["chunkSize"] == 50

0 commit comments

Comments
 (0)