Skip to content

Commit c23e31d

Browse files
committed
fix: guard against None after Mapping extraction, prevent request_params overriding core fields
- Add second None check in _normalize_token_id_sequence after extracting from a Mapping, since .get() can return None even when the key exists - Move request_params spread before explicit keys (model, prompt, temperature, max_tokens, logprobs) so they cannot be silently overridden by stray entries in request_params Made-with: Cursor
1 parent b7c0cb0 commit c23e31d

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

eval_protocol/integrations/fireworks_v1_completions_client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ def _normalize_token_id_sequence(values: Any) -> List[int]:
7272
return []
7373
if isinstance(values, Mapping):
7474
values = values.get("input_ids", values.get("ids", []))
75+
if values is None:
76+
return []
7577
if hasattr(values, "tolist") and not isinstance(values, list):
7678
values = values.tolist()
7779
if isinstance(values, tuple):
@@ -347,12 +349,12 @@ async def create_completion_from_prompt_ids(
347349
active_tools = tools if tools is not None else (self.default_tools or None)
348350
normalized_prompt_token_ids = [int(x) for x in list(prompt_token_ids)]
349351
request_payload = {
352+
**self.request_params,
350353
"model": self.model_id,
351354
"prompt": normalized_prompt_token_ids,
352355
"temperature": self.temperature,
353356
"max_tokens": self.max_tokens,
354357
"logprobs": True if self.logprobs else None,
355-
**self.request_params,
356358
}
357359
if not self.logprobs:
358360
request_payload.pop("logprobs", None)

0 commit comments

Comments
 (0)