Skip to content

Commit c5ec065

Browse files
committed
reverts
1 parent 7dafec8 commit c5ec065

6 files changed

Lines changed: 17 additions & 152 deletions

File tree

development/utils/subprocess_manager.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
import os
33
import re # Added for Serveo URL parsing
44
import shutil # Added for checking ssh availability
5-
6-
# import signal
5+
import signal
76
import subprocess
87
import time
98
from typing import IO, Any, Dict, List, Optional # Added IO, Any, List, Dict, Optional

eval_protocol/cli_commands/deploy.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@
1919
# Import functions with explicit names to match expected signatures
2020
from development.utils.subprocess_manager import (
2121
start_ngrok_and_get_url as _start_ngrok_and_get_url,
22-
)
23-
from development.utils.subprocess_manager import start_process as _start_process
24-
from development.utils.subprocess_manager import (
22+
start_process as _start_process,
2523
start_serveo_and_get_url as _start_serveo_and_get_url,
24+
stop_process as _stop_process,
2625
)
27-
from development.utils.subprocess_manager import stop_process as _stop_process
2826
except ImportError:
2927
# Fallback implementations when development module is not available
30-
# import signal
28+
import signal
3129
import socket
3230
import subprocess
3331

@@ -81,9 +79,12 @@ def start_ngrok_and_get_url(local_port, log_path):
8179

8280

8381
from eval_protocol.auth import get_fireworks_account_id
84-
from eval_protocol.config import GCPCloudRunConfig, RewardKitConfig
85-
from eval_protocol.config import _config_file_path as global_loaded_config_path
86-
from eval_protocol.config import get_config
82+
from eval_protocol.config import (
83+
GCPCloudRunConfig,
84+
RewardKitConfig,
85+
_config_file_path as global_loaded_config_path,
86+
get_config,
87+
)
8788
from eval_protocol.evaluation import create_evaluation
8889
from eval_protocol.gcp_tools import (
8990
build_and_push_docker_image,

eval_protocol/pytest/default_mcp_gym_rollout_processor.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import asyncio
22
import atexit
33
import os
4+
import signal
45
import socket
56
import subprocess
7+
import threading
68
import time
79
from pathlib import Path
810
from typing import List, Optional
@@ -180,8 +182,9 @@ def _signal_handler(cls, signum, frame):
180182
def _register_cleanup_handlers(cls):
181183
"""Register cleanup handlers - called only once"""
182184
atexit.register(cls._cleanup_all_servers)
183-
# signal.signal(signal.SIGINT, cls._signal_handler) # Ctrl+C
184-
# signal.signal(signal.SIGTERM, cls._signal_handler) # Termination signal
185+
if threading.current_thread() is threading.main_thread():
186+
signal.signal(signal.SIGINT, cls._signal_handler) # Ctrl+C
187+
signal.signal(signal.SIGTERM, cls._signal_handler) # Termination signal
185188

186189
def __enter__(self):
187190
"""Context manager entry"""

eval_protocol/rewards/apps_testing_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import re # Added for re.search
2424

2525
# to run the solution files we're using a timing based approach
26-
# import signal
26+
import signal
2727
import sys
2828
import textwrap # Added for dedenting model output
2929
import traceback

eval_protocol/rewards/code_execution.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
import re
2222
import resource
2323
import shlex # Added for robust splitting of arguments
24-
25-
# import signal
24+
import signal
2625
import subprocess
2726
import sys
2827
import tempfile

examples/gym_2048/gym_2048_adapter.py

Lines changed: 0 additions & 137 deletions
This file was deleted.

0 commit comments

Comments
 (0)