Skip to content

Commit e87ba81

Browse files
Keep base_url in completion_params; strip at OpenAI call site.
Use get() in build_init_request so base_url remains available for gateway URL encoding, and filter it out in remote_server when calling the SDK. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent b8f2d81 commit e87ba81

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

eval_protocol/pytest/tracing_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ def build_init_request(
103103
if not completion_params_dict.get("model"):
104104
raise ValueError("Model must be provided in completion_params")
105105

106-
# Extract base_url from completion_params (encoded into gateway path, not sent to OpenAI SDK)
107-
completion_params_base_url: Optional[str] = completion_params_dict.pop("base_url", None)
106+
# Extract base_url from completion_params for tracing-gateway URL encoding
107+
completion_params_base_url: Optional[str] = completion_params_dict.get("base_url")
108108

109109
# Strip non-OpenAI fields from messages
110110
# Use dump_mdoel_for_chat_completion_request() to automatically exclude unsupported fields (weight, control_plane_step, reasoning_content)

tests/remote_server/remote_server.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,12 @@ def _worker():
5555
md = {k: v for k, v in md.items() if v is not None}
5656
messages_payload.append(md)
5757

58-
# Spread all completion_params (model, temperature, max_tokens, etc.)
59-
completion_kwargs = {"messages": messages_payload, **req.completion_params}
58+
# Spread completion_params; omit base_url (client uses req.model_base_url; gateway
59+
# encodes inference base_url into the tracing path via build_init_request).
60+
completion_kwargs = {
61+
"messages": messages_payload,
62+
**{k: v for k, v in req.completion_params.items() if k != "base_url"},
63+
}
6064

6165
if req.tools:
6266
completion_kwargs["tools"] = req.tools

0 commit comments

Comments
 (0)