Skip to content

fix: Don't cache timeout/error results in LeanProver #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haasonsaas merged 2 commits into from
Apr 11, 2026
Merged

fix: Don't cache timeout/error results in LeanProver #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da8e4e1
fix: Don't cache timeout/error results in LeanProver
haasonsaas Apr 11, 2026
38c35c9
fix: Move cache.put after try/except to avoid swallowing valid results
haasonsaas Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions formal_verification/lean_prover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def prove_specification(self, spec: FormalSpec) -> ProofResult:
result = self._run_lean(lean_code, start_time, spec)
except subprocess.TimeoutExpired:
logger.warning("Lean proof timeout for: %s", spec.spec_text)
result = ProofResult(
return ProofResult(
spec=spec,
proven=False,
proof_time_ms=self.timeout_seconds * 1000,
Expand All @@ -126,7 +126,7 @@ def prove_specification(self, spec: FormalSpec) -> ProofResult:
)
except Exception as exc:
logger.error("Lean proof attempt failed: %s", exc)
result = ProofResult(
return ProofResult(
spec=spec,
proven=False,
proof_time_ms=(time.time() - start_time) * 1000,
Expand Down