Add LSP-backed symbol indexing and feedback CI helper

Author: haasonsaas

.diffscope.yml.example

@@ -14,6 +14,8 @@ review_instructions: |
 smart_review_summary: true   # Include AI-generated PR summary in smart-review output
 smart_review_diagram: false  # Generate a Mermaid diagram in smart-review output
 symbol_index: true           # Build repo symbol index for cross-file context (respects .gitignore)
+symbol_index_provider: regex # regex | lsp
+symbol_index_lsp_command: rust-analyzer
 symbol_index_max_files: 500
 symbol_index_max_bytes: 200000
 symbol_index_max_locations: 5

README.md

@@ -199,6 +199,8 @@ review_instructions: |
 smart_review_summary: true   # Include AI-generated PR summary in smart-review output
 smart_review_diagram: false  # Generate a Mermaid diagram in smart-review output
 symbol_index: true           # Build repo symbol index for cross-file context (respects .gitignore)
+symbol_index_provider: regex # regex | lsp
+symbol_index_lsp_command: rust-analyzer
 symbol_index_max_files: 500
 symbol_index_max_bytes: 200000
 symbol_index_max_locations: 5
@@ -219,6 +221,8 @@ exclude_patterns:
   - "**/__pycache__/**"
 ```
 
+Set `symbol_index_provider: lsp` to use a language server for Rust (via `rust-analyzer`); it falls back to regex indexing if the LSP binary is missing.
+
 ## Plugin Development
 
 Create custom analyzers:
@@ -650,6 +654,18 @@ diffscope feedback --accept review.json
 
 The feedback file defaults to `.diffscope.feedback.json` and can be configured in `.diffscope.yml`.
 
+**CI helper (GitHub Actions):**
+
+```yaml
+- name: Update DiffScope feedback
+  if: always()
+  run: |
+    bash scripts/update_feedback_from_review.sh \
+      --action reject \
+      --input review.json \
+      --feedback .diffscope.feedback.json
+```
+
 ### 📊 PR Summary Generation
 
 Generate executive summaries for pull requests:

scripts/update_feedback_from_review.sh

@@ -0,0 +1,65 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+usage() {
+  echo "Usage: $0 --action accept|reject --input review.json [--feedback .diffscope.feedback.json]" >&2
+  exit 1
+}
+
+ACTION=""
+INPUT=""
+FEEDBACK_PATH=""
+
+while [[ $# -gt 0 ]]; do
+  case "$1" in
+    --action)
+      ACTION="$2"
+      shift 2
+      ;;
+    --input)
+      INPUT="$2"
+      shift 2
+      ;;
+    --feedback)
+      FEEDBACK_PATH="$2"
+      shift 2
+      ;;
+    *)
+      usage
+      ;;
+  esac
+done
+
+if [[ -z "${ACTION}" || -z "${INPUT}" ]]; then
+  usage
+fi
+
+if [[ "${ACTION}" != "accept" && "${ACTION}" != "reject" ]]; then
+  echo "Invalid action: ${ACTION}" >&2
+  usage
+fi
+
+if [[ ! -f "${INPUT}" ]]; then
+  echo "Input file not found: ${INPUT}" >&2
+  exit 1
+fi
+
+CMD=()
+if command -v diffscope >/dev/null 2>&1; then
+  CMD=(diffscope feedback)
+else
+  CMD=(cargo run --quiet -- feedback)
+fi
+
+if [[ "${ACTION}" == "accept" ]]; then
+  CMD+=(--accept "${INPUT}")
+else
+  CMD+=(--reject "${INPUT}")
+fi
+
+if [[ -n "${FEEDBACK_PATH}" ]]; then
+  CMD+=(--feedback-path "${FEEDBACK_PATH}")
+fi
+
+echo "Running: ${CMD[*]}" >&2
+exec "${CMD[@]}"

src/config.rs

@@ -38,6 +38,9 @@ pub struct Config {
     #[serde(default = "default_true")]
     pub symbol_index: bool,
 
+    #[serde(default = "default_symbol_index_provider")]
+    pub symbol_index_provider: String,
+
     #[serde(default = "default_symbol_index_max_files")]
     pub symbol_index_max_files: usize,
 
@@ -47,6 +50,9 @@ pub struct Config {
     #[serde(default = "default_symbol_index_max_locations")]
     pub symbol_index_max_locations: usize,
 
+    #[serde(default)]
+    pub symbol_index_lsp_command: Option<String>,
+
     #[serde(default = "default_feedback_path")]
     pub feedback_path: PathBuf,
 
@@ -125,9 +131,11 @@ impl Default for Config {
             smart_review_summary: true,
             smart_review_diagram: false,
             symbol_index: true,
+            symbol_index_provider: default_symbol_index_provider(),
             symbol_index_max_files: default_symbol_index_max_files(),
             symbol_index_max_bytes: default_symbol_index_max_bytes(),
             symbol_index_max_locations: default_symbol_index_max_locations(),
+            symbol_index_lsp_command: None,
             feedback_path: default_feedback_path(),
             system_prompt: None,
             api_key: None,
@@ -204,6 +212,19 @@ impl Config {
             self.symbol_index_max_locations = default_symbol_index_max_locations();
         }
 
+        let provider = self.symbol_index_provider.trim().to_lowercase();
+        if provider.is_empty() || !matches!(provider.as_str(), "regex" | "lsp") {
+            self.symbol_index_provider = default_symbol_index_provider();
+        } else {
+            self.symbol_index_provider = provider;
+        }
+
+        if let Some(command) = &self.symbol_index_lsp_command {
+            if command.trim().is_empty() {
+                self.symbol_index_lsp_command = None;
+            }
+        }
+
         if !self.min_confidence.is_finite() {
             self.min_confidence = default_min_confidence();
         } else if !(0.0..=1.0).contains(&self.min_confidence) {
@@ -342,6 +363,10 @@ fn default_symbol_index_max_locations() -> usize {
     5
 }
 
+fn default_symbol_index_provider() -> String {
+    "regex".to_string()
+}
+
 fn default_feedback_path() -> PathBuf {
     PathBuf::from(".diffscope.feedback.json")
 }