refactor: split feedback input conversion helpers

Separate review-session expansion from feedback label normalization so input conversion paths can evolve without sharing unrelated helper code.

Made-with: Cursor

Author: haasonsaas

TODO.md

@@ -80,7 +80,7 @@
 - [ ] `src/commands/eval/types.rs`: split fixture, pattern, report, and run-option types if churn keeps touching unrelated structs.
 - [ ] `src/commands/feedback_eval/types.rs`: separate input payload types from report/output types.
 - [x] `src/commands/feedback_eval/input/loading.rs`: split format detection from JSON parsing/loading.
-- [ ] `src/commands/feedback_eval/input/conversion.rs`: split review-session conversion from label normalization helpers.
+- [x] `src/commands/feedback_eval/input/conversion.rs`: split review-session conversion from label normalization helpers.
 - [ ] `src/commands/pr.rs`: separate summary-only flow, full review flow, and comment-posting orchestration.
 - [ ] `src/commands/pr/gh.rs`: carve PR resolution, diff fetching, and metadata fetching.
 - [ ] `src/commands/git/suggest.rs`: split commit-message prompting from PR-title prompting and response extraction.

src/commands/feedback_eval/input/conversion.rs

@@ -1,69 +1,9 @@
-use crate::core;
-use crate::review;
-use crate::server::state::ReviewSession;
-
-use super::super::{FeedbackEvalComment, LoadedFeedbackEvalInput};
-
-pub(super) fn extend_from_review_session(
-    loaded: &mut LoadedFeedbackEvalInput,
-    review_id: Option<String>,
-    session: ReviewSession,
-) {
-    let repo = session
-        .event
-        .as_ref()
-        .and_then(|event| event.github_repo.clone());
-    let pr_number = session.event.as_ref().and_then(|event| event.github_pr);
-    let title = session.event.as_ref().and_then(|event| event.title.clone());
-
-    loaded.total_reviews_seen += 1;
-    loaded.total_comments_seen += session.comments.len();
-    loaded
-        .comments
-        .extend(session.comments.into_iter().filter_map(|comment| {
-            feedback_comment_from_comment(
-                "review-session",
-                review_id.clone(),
-                repo.clone(),
-                pr_number,
-                title.clone(),
-                comment,
-            )
-        }));
-}
-
-pub(super) fn feedback_comment_from_comment(
-    source_kind: &str,
-    review_id: Option<String>,
-    repo: Option<String>,
-    pr_number: Option<u32>,
-    title: Option<String>,
-    comment: core::Comment,
-) -> Option<FeedbackEvalComment> {
-    let accepted = normalize_feedback_label(comment.feedback.as_deref()?)?;
-    let file_patterns = review::derive_file_patterns(&comment.file_path);
-
-    Some(FeedbackEvalComment {
-        source_kind: source_kind.to_string(),
-        review_id,
-        repo,
-        pr_number,
-        title,
-        file_path: Some(comment.file_path),
-        line_number: Some(comment.line_number),
-        file_patterns,
-        content: comment.content,
-        category: comment.category.to_string(),
-        severity: Some(comment.severity.to_string()),
-        confidence: Some(comment.confidence),
-        accepted,
-    })
-}
-
-fn normalize_feedback_label(label: &str) -> Option<bool> {
-    match label.trim().to_ascii_lowercase().as_str() {
-        "accept" | "accepted" => Some(true),
-        "reject" | "rejected" => Some(false),
-        _ => None,
-    }
-}
+#[path = "conversion/comment.rs"]
+mod comment;
+#[path = "conversion/labels.rs"]
+mod labels;
+#[path = "conversion/session.rs"]
+mod session;
+
+pub(super) use comment::feedback_comment_from_comment;
+pub(super) use session::extend_from_review_session;

src/commands/feedback_eval/input/conversion/comment.rs

@@ -0,0 +1,33 @@
+use crate::core;
+use crate::review;
+
+use super::super::super::FeedbackEvalComment;
+use super::labels::normalize_feedback_label;
+
+pub(in super::super) fn feedback_comment_from_comment(
+    source_kind: &str,
+    review_id: Option<String>,
+    repo: Option<String>,
+    pr_number: Option<u32>,
+    title: Option<String>,
+    comment: core::Comment,
+) -> Option<FeedbackEvalComment> {
+    let accepted = normalize_feedback_label(comment.feedback.as_deref()?)?;
+    let file_patterns = review::derive_file_patterns(&comment.file_path);
+
+    Some(FeedbackEvalComment {
+        source_kind: source_kind.to_string(),
+        review_id,
+        repo,
+        pr_number,
+        title,
+        file_path: Some(comment.file_path),
+        line_number: Some(comment.line_number),
+        file_patterns,
+        content: comment.content,
+        category: comment.category.to_string(),
+        severity: Some(comment.severity.to_string()),
+        confidence: Some(comment.confidence),
+        accepted,
+    })
+}

src/commands/feedback_eval/input/conversion/labels.rs

@@ -0,0 +1,7 @@
+pub(super) fn normalize_feedback_label(label: &str) -> Option<bool> {
+    match label.trim().to_ascii_lowercase().as_str() {
+        "accept" | "accepted" => Some(true),
+        "reject" | "rejected" => Some(false),
+        _ => None,
+    }
+}

src/commands/feedback_eval/input/conversion/session.rs

@@ -0,0 +1,32 @@
+use crate::server::state::ReviewSession;
+
+use super::super::super::LoadedFeedbackEvalInput;
+use super::comment::feedback_comment_from_comment;
+
+pub(in super::super) fn extend_from_review_session(
+    loaded: &mut LoadedFeedbackEvalInput,
+    review_id: Option<String>,
+    session: ReviewSession,
+) {
+    let repo = session
+        .event
+        .as_ref()
+        .and_then(|event| event.github_repo.clone());
+    let pr_number = session.event.as_ref().and_then(|event| event.github_pr);
+    let title = session.event.as_ref().and_then(|event| event.title.clone());
+
+    loaded.total_reviews_seen += 1;
+    loaded.total_comments_seen += session.comments.len();
+    loaded
+        .comments
+        .extend(session.comments.into_iter().filter_map(|comment| {
+            feedback_comment_from_comment(
+                "review-session",
+                review_id.clone(),
+                repo.clone(),
+                pr_number,
+                title.clone(),
+                comment,
+            )
+        }));
+}