refactor: split pipeline into domain modules

Author: haasonsaas

TODO.md

@@ -0,0 +1,64 @@
+# Pipeline Refactor TODO
+
+## Goals
+
+- [x] Split `src/review/pipeline/helpers.rs` into focused modules with clearer ownership.
+- [x] Introduce shared pipeline session/services types so preparation, execution, and post-processing stop threading long parameter lists.
+- [x] Extract post-processing and verification orchestration into a dedicated pipeline submodule.
+- [x] Move pipeline tests out of `src/review/pipeline.rs` and colocate them with the modules that own the behavior.
+- [x] Keep the refactor behavior-preserving and validate with `cargo fmt`, `cargo clippy --all-targets --all-features -- -D warnings`, and `cargo test`.
+
+## Planned module split
+
+### 1. Shared pipeline state
+
+- [x] Create `src/review/pipeline/types.rs` for shared pipeline result/progress types.
+- [x] Create `src/review/pipeline/session.rs` for `PipelineServices` and `ReviewSession` plus runtime/repo helpers:
+  - local-model optimization detection
+  - diff chunking
+  - instruction file detection
+  - git log gathering
+  - convention store path resolution and saving
+
+### 2. Context and guidance
+
+- [x] Create `src/review/pipeline/context.rs` for:
+  - symbol extraction from diffs
+  - symbol index construction
+  - related-file context gathering
+  - test-file discovery helper
+- [x] Create `src/review/pipeline/guidance.rs` for review guidance assembly.
+
+### 3. Comment preparation and execution support
+
+- [x] Create `src/review/pipeline/comments.rs` for:
+  - analyzer finding synthesis
+  - diff-line filtering
+  - analyzer comment detection
+- [x] Keep execution-specific validation and metric aggregation near `execution.rs`.
+
+### 4. Dedicated post-processing stage
+
+- [x] Create `src/review/pipeline/postprocess.rs` for:
+  - specialized-pass deduplication
+  - plugin post-processing orchestration
+  - verification pass orchestration
+  - semantic feedback confidence adjustment
+  - enhanced feedback adjustment
+  - review filtering, enhanced filters, and convention suppression
+
+### 5. Test relocation
+
+- [x] Move symbol/context tests into `context.rs`.
+- [x] Move guidance tests into `guidance.rs`.
+- [x] Move diff chunking tests into `session.rs`.
+- [x] Move response validation tests into `execution.rs`.
+- [x] Move comment filtering/dedup tests into `comments.rs` and `postprocess.rs`.
+- [x] Move prompt/config ownership tests to `src/core/prompt.rs` and `src/config.rs`.
+
+## Execution checklist
+
+- [x] Rewire `src/review/pipeline.rs` into a thin orchestration facade over the new modules.
+- [x] Run validators.
+- [x] Review git diff for scope and sensitive data.
+- [x] Commit and push the refactor.

src/config.rs

@@ -1508,6 +1508,12 @@ mod tests {
         assert!(config.base_url.is_none());
     }
 
+    #[test]
+    fn multi_pass_specialized_config_default_false() {
+        let config = Config::default();
+        assert!(!config.multi_pass_specialized);
+    }
+
     #[test]
     fn normalize_rejects_base_url_not_a_url() {
         let mut config = Config {

src/core/prompt.rs

@@ -607,4 +607,24 @@ mod tests {
         let unique: std::collections::HashSet<&&str> = tags.iter().collect();
         assert_eq!(unique.len(), tags.len());
     }
+
+    #[test]
+    fn specialized_prompts_are_distinct() {
+        let security = build_security_prompt();
+        let correctness = build_correctness_prompt();
+        let style = build_style_prompt();
+        assert!(security.contains("security"));
+        assert!(correctness.contains("correctness"));
+        assert!(style.contains("style"));
+        assert_ne!(security, correctness);
+        assert_ne!(security, style);
+        assert_ne!(correctness, style);
+    }
+
+    #[test]
+    fn specialized_pass_kind_tags() {
+        assert_eq!(SpecializedPassKind::Security.tag(), "security-pass");
+        assert_eq!(SpecializedPassKind::Correctness.tag(), "correctness-pass");
+        assert_eq!(SpecializedPassKind::Style.tag(), "style-pass");
+    }
 }