fix: address PR37 review feedback — zero line counts and verification enum YAML (#41)

- diff_parser: add regression assertions for @@ -0,0 +1,N @@ and @@ -N,N +0,0 @@
  so zero line counts are preserved (Bugbot/CRITICAL). Add TDD test
  test_parse_new_file_multi_line_zero_old_lines. Main already uses
  parse_optional_capture without a zero filter; tests would fail if re-introduced.
- config: add tests that deserialize verification_model_role and
  verification_consensus_mode from YAML (flat keys into config.verification).
  Assert weak/majority and primary/all; use config.verification.* after
  VerificationConfig flatten refactor.

Made-with: Cursor

Author: haasonsaas

src/config.rs

@@ -2113,6 +2113,40 @@ temperature: 0.3
         );
     }
 
+    #[test]
+    fn test_config_deserialize_verification_enum_fields_from_yaml() {
+        // Regression (PR37): flattened verification_model_role / verification_consensus_mode
+        // must deserialize from YAML. serde_yaml can have issues with enums in flattened
+        // structs; this test locks in that config.verification (flatten) works.
+        let yaml = r#"
+model: claude-sonnet-4-6
+verification_model_role: weak
+verification_consensus_mode: majority
+"#;
+        let config: Config = serde_yaml::from_str(yaml).unwrap();
+        assert_eq!(config.verification.model_role, ModelRole::Weak);
+        assert_eq!(
+            config.verification.consensus_mode,
+            VerificationConsensusMode::Majority
+        );
+    }
+
+    #[test]
+    fn test_config_deserialize_verification_enum_primary_and_all() {
+        // TDD: prove enum variants deserialize from YAML (primary, all).
+        let yaml = r#"
+model: claude-sonnet-4-6
+verification_model_role: primary
+verification_consensus_mode: all
+"#;
+        let config: Config = serde_yaml::from_str(yaml).unwrap();
+        assert_eq!(config.verification.model_role, ModelRole::Primary);
+        assert_eq!(
+            config.verification.consensus_mode,
+            VerificationConsensusMode::All
+        );
+    }
+
     #[test]
     fn test_default_frontier_role_models_match_requested_pair() {
         let config = Config::default();

src/core/diff_parser.rs

@@ -556,8 +556,10 @@ index 83db48f..0000000\n\
         assert_eq!(diffs.len(), 1);
         assert!(diffs[0].is_deleted);
         assert!(!diffs[0].is_new);
-        assert_eq!(diffs[0].hunks[0].old_lines, 1);
-        assert_eq!(diffs[0].hunks[0].new_lines, 0);
+        // Regression (PR37): @@ -1,1 +0,0 @@ must preserve old_lines=1, new_lines=0
+        let hunk = &diffs[0].hunks[0];
+        assert_eq!(hunk.old_lines, 1, "deleted-file hunk must have old_lines=1");
+        assert_eq!(hunk.new_lines, 0, "deleted-file hunk must have new_lines=0");
     }
 
     #[test]
@@ -575,8 +577,33 @@ index 0000000..f735c20\n\
         assert_eq!(diffs.len(), 1);
         assert!(diffs[0].is_new);
         assert!(!diffs[0].is_deleted);
-        assert_eq!(diffs[0].hunks[0].old_lines, 0);
-        assert_eq!(diffs[0].hunks[0].new_lines, 1);
+        // Regression (PR37): @@ -0,0 +1,1 @@ must preserve old_lines=0, new_lines=1
+        let hunk = &diffs[0].hunks[0];
+        assert_eq!(hunk.old_lines, 0, "new-file hunk must have old_lines=0");
+        assert_eq!(hunk.new_lines, 1, "new-file hunk must have new_lines=1");
+    }
+
+    #[test]
+    fn test_parse_new_file_multi_line_zero_old_lines() {
+        // TDD: @@ -0,0 +1,5 @@ must yield old_lines=0, new_lines=5
+        let diff_text = "\
+diff --git a/new.txt b/new.txt\n\
+new file mode 100644\n\
+index 0000000..abc1234\n\
+--- /dev/null\n\
++++ b/new.txt\n\
+@@ -0,0 +1,5 @@\n\
++line1\n\
++line2\n\
++line3\n\
++line4\n\
++line5\n";
+        let diffs = DiffParser::parse_unified_diff(diff_text).unwrap();
+        assert_eq!(diffs.len(), 1);
+        let hunk = &diffs[0].hunks[0];
+        assert_eq!(hunk.old_lines, 0, "zero old_lines must be preserved");
+        assert_eq!(hunk.new_lines, 5, "new_lines=5 must be preserved");
+        assert_eq!(hunk.changes.len(), 5, "all 5 added lines must be parsed");
     }
 
     #[test]