refactor: split feedback apply helpers

Separate acceptance and rejection mutation loops from feedback stats bookkeeping so store updates stay easier to reason about.

Made-with: Cursor

Author: haasonsaas

TODO.md

@@ -86,7 +86,7 @@
 - [x] `src/commands/git/suggest.rs`: split commit-message prompting from PR-title prompting and response extraction.
 - [x] `src/commands/review/command.rs`: split review/check/compare entrypoints if they keep diverging.
 - [x] `src/commands/misc/feedback/command.rs`: separate file loading/ID normalization from store persistence.
-- [ ] `src/commands/misc/feedback/apply.rs`: split acceptance/rejection counters from store mutation helpers.
+- [x] `src/commands/misc/feedback/apply.rs`: split acceptance/rejection counters from store mutation helpers.
 - [ ] `src/commands/misc/discussion/command.rs`: separate the interactive loop from single-shot execution.
 - [ ] `src/commands/misc/discussion/selection.rs`: split file loading/ID repair from selection rules.
 - [ ] `src/commands/misc/changelog.rs`: evaluate splitting changelog collection from output formatting.

src/commands/misc/feedback/apply.rs

@@ -1,86 +1,9 @@
-use crate::core;
-use crate::review;
-
-pub(super) fn apply_feedback_accept(
-    store: &mut review::FeedbackStore,
-    comments: &[core::Comment],
-) -> usize {
-    let mut updated = 0;
-    for comment in comments {
-        let is_new = store.accept.insert(comment.id.clone());
-        if is_new {
-            updated += 1;
-            let key = review::classify_comment_type(comment).as_str().to_string();
-            let stats = store.by_comment_type.entry(key).or_default();
-            stats.accepted = stats.accepted.saturating_add(1);
-            let file_patterns = review::derive_file_patterns(&comment.file_path);
-            store.record_feedback_patterns(&comment.category.to_string(), &file_patterns, true);
-        }
-        store.suppress.remove(&comment.id);
-    }
-    updated
-}
-
-pub(super) fn apply_feedback_reject(
-    store: &mut review::FeedbackStore,
-    comments: &[core::Comment],
-) -> usize {
-    let mut updated = 0;
-    for comment in comments {
-        let is_new = store.suppress.insert(comment.id.clone());
-        if is_new {
-            updated += 1;
-            let key = review::classify_comment_type(comment).as_str().to_string();
-            let stats = store.by_comment_type.entry(key).or_default();
-            stats.rejected = stats.rejected.saturating_add(1);
-            let file_patterns = review::derive_file_patterns(&comment.file_path);
-            store.record_feedback_patterns(&comment.category.to_string(), &file_patterns, false);
-        }
-        store.accept.remove(&comment.id);
-    }
-    updated
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use std::path::PathBuf;
-
-    #[test]
-    fn test_feedback_stats_not_double_counted() {
-        let mut store = review::FeedbackStore::default();
-        let comment = core::Comment {
-            id: "cmt_dup".to_string(),
-            file_path: PathBuf::from("test.rs"),
-            line_number: 1,
-            content: "test".to_string(),
-            rule_id: None,
-            severity: core::comment::Severity::Warning,
-            category: core::comment::Category::Bug,
-            suggestion: None,
-            confidence: 0.8,
-            code_suggestion: None,
-            tags: vec![],
-            fix_effort: core::comment::FixEffort::Low,
-            feedback: None,
-        };
-
-        let comments = vec![comment];
-
-        for _ in 0..2 {
-            apply_feedback_accept(&mut store, &comments);
-        }
-
-        let key = review::classify_comment_type(&comments[0])
-            .as_str()
-            .to_string();
-        let stats = &store.by_comment_type[&key];
-        assert_eq!(
-            stats.accepted, 1,
-            "Stats should only count 1 acceptance, not 2 (double-counting bug)"
-        );
-        assert_eq!(store.by_category["Bug"].accepted, 1);
-        assert_eq!(store.by_file_pattern["*.rs"].accepted, 1);
-        assert_eq!(store.by_category_file_pattern["Bug|*.rs"].accepted, 1);
-    }
-}
+#[path = "apply/accept.rs"]
+mod accept;
+#[path = "apply/reject.rs"]
+mod reject;
+#[path = "apply/stats.rs"]
+mod stats;
+
+pub(super) use accept::apply_feedback_accept;
+pub(super) use reject::apply_feedback_reject;

src/commands/misc/feedback/apply/accept.rs

@@ -0,0 +1,64 @@
+use crate::core;
+use crate::review;
+
+use super::stats::record_accepted_feedback;
+
+pub(in super::super) fn apply_feedback_accept(
+    store: &mut review::FeedbackStore,
+    comments: &[core::Comment],
+) -> usize {
+    let mut updated = 0;
+    for comment in comments {
+        let is_new = store.accept.insert(comment.id.clone());
+        if is_new {
+            updated += 1;
+            record_accepted_feedback(store, comment);
+        }
+        store.suppress.remove(&comment.id);
+    }
+    updated
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use std::path::PathBuf;
+
+    #[test]
+    fn test_feedback_stats_not_double_counted() {
+        let mut store = review::FeedbackStore::default();
+        let comment = core::Comment {
+            id: "cmt_dup".to_string(),
+            file_path: PathBuf::from("test.rs"),
+            line_number: 1,
+            content: "test".to_string(),
+            rule_id: None,
+            severity: core::comment::Severity::Warning,
+            category: core::comment::Category::Bug,
+            suggestion: None,
+            confidence: 0.8,
+            code_suggestion: None,
+            tags: vec![],
+            fix_effort: core::comment::FixEffort::Low,
+            feedback: None,
+        };
+
+        let comments = vec![comment];
+
+        for _ in 0..2 {
+            apply_feedback_accept(&mut store, &comments);
+        }
+
+        let key = review::classify_comment_type(&comments[0])
+            .as_str()
+            .to_string();
+        let stats = &store.by_comment_type[&key];
+        assert_eq!(
+            stats.accepted, 1,
+            "Stats should only count 1 acceptance, not 2 (double-counting bug)"
+        );
+        assert_eq!(store.by_category["Bug"].accepted, 1);
+        assert_eq!(store.by_file_pattern["*.rs"].accepted, 1);
+        assert_eq!(store.by_category_file_pattern["Bug|*.rs"].accepted, 1);
+    }
+}

src/commands/misc/feedback/apply/reject.rs

@@ -0,0 +1,20 @@
+use crate::core;
+use crate::review;
+
+use super::stats::record_rejected_feedback;
+
+pub(in super::super) fn apply_feedback_reject(
+    store: &mut review::FeedbackStore,
+    comments: &[core::Comment],
+) -> usize {
+    let mut updated = 0;
+    for comment in comments {
+        let is_new = store.suppress.insert(comment.id.clone());
+        if is_new {
+            updated += 1;
+            record_rejected_feedback(store, comment);
+        }
+        store.accept.remove(&comment.id);
+    }
+    updated
+}

src/commands/misc/feedback/apply/stats.rs

@@ -0,0 +1,27 @@
+use crate::core;
+use crate::review;
+
+pub(super) fn record_accepted_feedback(store: &mut review::FeedbackStore, comment: &core::Comment) {
+    record_feedback_stats(store, comment, true);
+}
+
+pub(super) fn record_rejected_feedback(store: &mut review::FeedbackStore, comment: &core::Comment) {
+    record_feedback_stats(store, comment, false);
+}
+
+fn record_feedback_stats(
+    store: &mut review::FeedbackStore,
+    comment: &core::Comment,
+    accepted: bool,
+) {
+    let key = review::classify_comment_type(comment).as_str().to_string();
+    let stats = store.by_comment_type.entry(key).or_default();
+    if accepted {
+        stats.accepted = stats.accepted.saturating_add(1);
+    } else {
+        stats.rejected = stats.rejected.saturating_add(1);
+    }
+
+    let file_patterns = review::derive_file_patterns(&comment.file_path);
+    store.record_feedback_patterns(&comment.category.to_string(), &file_patterns, accepted);
+}