feat: separate blocking and informational findings

Split open review findings into blocking and informational buckets so merge readiness surfaces can highlight true blockers and the review detail page can call out unresolved error and warning findings explicitly.

Made-with: Cursor

Author: haasonsaas

TODO.md

@@ -40,8 +40,8 @@ This roadmap is derived from deep research into Greptile's public docs, blog, MC
 13. [x] Compute merge-readiness summaries for GitHub PR reviews using severity, unresolved count, and verification state.
 14. [x] Add stale-review detection when new commits land after the latest completed review.
 15. [x] Show "needs re-review" state in review detail and history pages for incremental PR workflows.
-16. [ ] Distinguish informational findings from blocking findings in lifecycle and readiness calculations.
-17. [ ] Add "critical blockers" summary cards for unresolved `Error` and `Warning` comments.
+16. [x] Distinguish informational findings from blocking findings in lifecycle and readiness calculations.
+17. [x] Add "critical blockers" summary cards for unresolved `Error` and `Warning` comments.
 18. [ ] Add per-PR readiness timelines showing when a review became mergeable.
 19. [ ] Store resolution timestamps for findings so mean-time-to-fix can be measured.
 20. [ ] Add CLI and API surfaces to query PR readiness without opening the web UI.
@@ -158,4 +158,5 @@ This roadmap is derived from deep research into Greptile's public docs, blog, MC
 - [x] Ship first-pass finding lifecycle state and lightweight merge readiness through the backend, API, CLI summaries, and review UI.
 - [x] Make merge readiness verification-aware and surface stale PR reviews as needs re-review in history/detail views.
 - [x] Make stale-review detection compare PR head SHAs so same-head reruns do not look stale.
+- [x] Split open findings into blocking vs informational buckets and surface critical blocker cards in review detail.
 - [ ] Commit and push each validated checkpoint before moving to the next epic.

src/core/comment/summary.rs

@@ -8,9 +8,12 @@ use super::{
 pub(super) fn generate_summary(comments: &[Comment]) -> ReviewSummary {
     let mut by_severity = HashMap::new();
     let mut by_category = HashMap::new();
+    let mut open_by_severity = HashMap::new();
     let mut files = HashSet::new();
     let mut critical_issues = 0;
     let mut open_comments = 0;
+    let mut open_blocking_comments = 0;
+    let mut open_informational_comments = 0;
     let mut resolved_comments = 0;
     let mut dismissed_comments = 0;
     let mut open_blockers = 0;
@@ -31,9 +34,16 @@ pub(super) fn generate_summary(comments: &[Comment]) -> ReviewSummary {
         match comment.status {
             CommentStatus::Open => {
                 open_comments += 1;
-                if matches!(comment.severity, Severity::Error | Severity::Warning) {
+                *open_by_severity
+                    .entry(comment.severity.to_string())
+                    .or_insert(0) += 1;
+                if comment.severity.is_blocking() {
+                    open_blocking_comments += 1;
                     open_blockers += 1;
                 }
+                if comment.severity.is_informational() {
+                    open_informational_comments += 1;
+                }
             }
             CommentStatus::Resolved => resolved_comments += 1,
             CommentStatus::Dismissed => dismissed_comments += 1,
@@ -49,6 +59,9 @@ pub(super) fn generate_summary(comments: &[Comment]) -> ReviewSummary {
         overall_score: calculate_overall_score(comments),
         recommendations: generate_recommendations(comments),
         open_comments,
+        open_by_severity,
+        open_blocking_comments,
+        open_informational_comments,
         resolved_comments,
         dismissed_comments,
         open_blockers,
@@ -220,9 +233,12 @@ mod tests {
         let summary = generate_summary(&comments);
         assert_eq!(summary.total_comments, 3);
         assert_eq!(summary.open_comments, 1);
+        assert_eq!(summary.open_blocking_comments, 1);
+        assert_eq!(summary.open_informational_comments, 0);
         assert_eq!(summary.resolved_comments, 1);
         assert_eq!(summary.dismissed_comments, 1);
         assert_eq!(summary.open_blockers, 1);
+        assert_eq!(summary.open_by_severity.get("Error"), Some(&1));
         assert_eq!(summary.merge_readiness, MergeReadiness::NeedsAttention);
         assert_eq!(
             summary.recommendations,
@@ -249,10 +265,44 @@ mod tests {
 
         let summary = generate_summary(&comments);
         assert_eq!(summary.open_blockers, 0);
+        assert_eq!(summary.open_blocking_comments, 0);
+        assert_eq!(summary.open_informational_comments, 0);
         assert_eq!(summary.merge_readiness, MergeReadiness::Ready);
         assert!(summary.recommendations.is_empty());
     }
 
+    #[test]
+    fn summary_distinguishes_blocking_and_informational_open_findings() {
+        let comments = vec![
+            make_comment(
+                "open-warning",
+                Severity::Warning,
+                Category::Bug,
+                CommentStatus::Open,
+            ),
+            make_comment(
+                "open-info",
+                Severity::Info,
+                Category::Documentation,
+                CommentStatus::Open,
+            ),
+            make_comment(
+                "open-suggestion",
+                Severity::Suggestion,
+                Category::Style,
+                CommentStatus::Open,
+            ),
+        ];
+
+        let summary = generate_summary(&comments);
+        assert_eq!(summary.open_comments, 3);
+        assert_eq!(summary.open_blocking_comments, 1);
+        assert_eq!(summary.open_informational_comments, 2);
+        assert_eq!(summary.open_by_severity.get("Warning"), Some(&1));
+        assert_eq!(summary.open_by_severity.get("Info"), Some(&1));
+        assert_eq!(summary.open_by_severity.get("Suggestion"), Some(&1));
+    }
+
     #[test]
     fn summary_needs_rereview_when_verification_is_inconclusive() {
         let comments = vec![make_comment(

src/core/comment/types.rs

@@ -44,6 +44,12 @@ pub struct ReviewSummary {
     #[serde(default)]
     pub open_comments: usize,
     #[serde(default)]
+    pub open_by_severity: HashMap<String, usize>,
+    #[serde(default)]
+    pub open_blocking_comments: usize,
+    #[serde(default)]
+    pub open_informational_comments: usize,
+    #[serde(default)]
     pub resolved_comments: usize,
     #[serde(default)]
     pub dismissed_comments: usize,
@@ -167,6 +173,14 @@ impl Severity {
             Severity::Suggestion => "suggestion",
         }
     }
+
+    pub fn is_blocking(&self) -> bool {
+        matches!(self, Severity::Error | Severity::Warning)
+    }
+
+    pub fn is_informational(&self) -> bool {
+        matches!(self, Severity::Info | Severity::Suggestion)
+    }
 }
 
 #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]

src/output/format.rs

@@ -91,6 +91,10 @@ pub fn format_as_markdown(comments: &[core::Comment], rule_priority: &[String])
         "⛔ **Open Blockers:** {}\n\n",
         summary.open_blockers
     ));
+    output.push_str(&format!(
+        "🚧 **Blocking Open:** {} | 💡 **Informational Open:** {}\n\n",
+        summary.open_blocking_comments, summary.open_informational_comments
+    ));
     output.push_str(&format!(
         "🧪 **Verification:** {}",
         summary.verification.state
@@ -307,6 +311,10 @@ pub fn format_smart_review_output(
         "⛔ **Open Blockers:** {}\n\n",
         summary.open_blockers
     ));
+    output.push_str(&format!(
+        "🚧 **Blocking Open:** {} | 💡 **Informational Open:** {}\n\n",
+        summary.open_blocking_comments, summary.open_informational_comments
+    ));
     output.push_str(&format!(
         "🧪 **Verification:** {}",
         summary.verification.state
@@ -899,6 +907,12 @@ mod tests {
             by_category: std::collections::HashMap::from([("Bug".to_string(), 2)]),
             recommendations: vec!["Fix bugs".to_string()],
             open_comments: 2,
+            open_by_severity: std::collections::HashMap::from([
+                ("Error".to_string(), 1),
+                ("Warning".to_string(), 1),
+            ]),
+            open_blocking_comments: 2,
+            open_informational_comments: 0,
             resolved_comments: 0,
             dismissed_comments: 0,
             open_blockers: 2,

src/review/rule_helpers/reporting/summary.rs

@@ -23,6 +23,10 @@ pub fn build_pr_summary_comment_body(
         summary.open_comments, summary.resolved_comments, summary.dismissed_comments
     ));
     body.push_str(&format!("- Open blockers: {}\n", summary.open_blockers));
+    body.push_str(&format!(
+        "- Blocking open: {} | Informational open: {}\n",
+        summary.open_blocking_comments, summary.open_informational_comments
+    ));
     body.push_str(&format!("- Verification: {}", summary.verification.state));
     if summary.verification.judge_count > 0 {
         body.push_str(&format!(

src/server/storage_json.rs

@@ -533,6 +533,9 @@ mod tests {
             overall_score: 8.0,
             recommendations: vec!["Fix bugs".to_string()],
             open_comments: 2,
+            open_by_severity: HashMap::from([("Warning".to_string(), 2)]),
+            open_blocking_comments: 2,
+            open_informational_comments: 0,
             resolved_comments: 0,
             dismissed_comments: 0,
             open_blockers: 2,

web/src/api/types.ts

@@ -41,6 +41,9 @@ export interface ReviewSummary {
   overall_score: number
   recommendations: string[]
   open_comments: number
+  open_by_severity: Record<string, number>
+  open_blocking_comments: number
+  open_informational_comments: number
   resolved_comments: number
   dismissed_comments: number
   open_blockers: number

web/src/pages/ReviewView.tsx

@@ -145,6 +145,9 @@ export function ReviewView() {
     Inconclusive: 'text-accent',
   }
 
+  const openErrorCount = review.summary?.open_by_severity.Error ?? 0
+  const openWarningCount = review.summary?.open_by_severity.Warning ?? 0
+
   return (
     <div className="flex h-full">
       {/* File sidebar */}
@@ -184,10 +187,16 @@ export function ReviewView() {
                   open
                 </span>
                 <span className="flex items-center gap-1">
-                  <span className={review.summary.open_blockers > 0 ? 'text-sev-warning' : 'text-sev-suggestion'}>
-                    {review.summary.open_blockers}
+                  <span className={review.summary.open_blocking_comments > 0 ? 'text-sev-warning' : 'text-sev-suggestion'}>
+                    {review.summary.open_blocking_comments}
                   </span>
-                  blocker{review.summary.open_blockers === 1 ? '' : 's'}
+                  blocking
+                </span>
+                <span className="flex items-center gap-1">
+                  <span className={review.summary.open_informational_comments > 0 ? 'text-accent' : 'text-text-muted'}>
+                    {review.summary.open_informational_comments}
+                  </span>
+                  informational
                 </span>
                 <span className="flex items-center gap-1">
                   <FileCode size={11} />
@@ -249,6 +258,35 @@ export function ReviewView() {
           </div>
         )}
 
+        {review.summary && (
+          <div className="px-3 py-3 border-b border-border bg-surface grid grid-cols-2 lg:grid-cols-4 gap-2">
+            <SummaryCard
+              label="Error Blockers"
+              value={openErrorCount}
+              hint="Open Error findings"
+              tone={openErrorCount > 0 ? 'error' : 'muted'}
+            />
+            <SummaryCard
+              label="Warning Blockers"
+              value={openWarningCount}
+              hint="Open Warning findings"
+              tone={openWarningCount > 0 ? 'warning' : 'muted'}
+            />
+            <SummaryCard
+              label="Blocking Open"
+              value={review.summary.open_blocking_comments}
+              hint="Error + Warning"
+              tone={review.summary.open_blocking_comments > 0 ? 'warning' : 'muted'}
+            />
+            <SummaryCard
+              label="Informational Open"
+              value={review.summary.open_informational_comments}
+              hint="Info + Suggestion"
+              tone={review.summary.open_informational_comments > 0 ? 'accent' : 'muted'}
+            />
+          </div>
+        )}
+
         {/* Toolbar */}
         <div className="px-3 py-2 border-b border-border bg-surface flex items-center gap-2">
           {/* View mode toggle */}
@@ -373,6 +411,35 @@ export function ReviewView() {
   )
 }
 
+function SummaryCard(
+  {
+    label,
+    value,
+    hint,
+    tone,
+  }: {
+    label: string
+    value: number
+    hint: string
+    tone: 'error' | 'warning' | 'accent' | 'muted'
+  },
+) {
+  const toneStyles = {
+    error: 'border-sev-error/20 bg-sev-error/5 text-sev-error',
+    warning: 'border-sev-warning/20 bg-sev-warning/5 text-sev-warning',
+    accent: 'border-accent/20 bg-accent/5 text-accent',
+    muted: 'border-border bg-surface-1 text-text-muted',
+  }
+
+  return (
+    <div className={`rounded-lg border px-3 py-2 ${toneStyles[tone]}`}>
+      <div className="text-[10px] font-code uppercase tracking-[0.08em]">{label}</div>
+      <div className="mt-1 text-lg font-semibold text-text-primary">{value}</div>
+      <div className="text-[11px]">{hint}</div>
+    </div>
+  )
+}
+
 function ProgressBanner({ progress, comments }: { progress?: import('../api/types').ReviewProgress, comments: number }) {
   if (!progress) {
     return (