chore: sync public mirror from internal#781
Conversation
PR SummaryHigh Risk Overview GitHub agent autonomous runs now require EvalOps delegation ( Slack agent defaults to Docker sandbox (host mode blocked unless Daytona sandbox gains session-based exec with abort signals, output caps, and shared shell/env building for Composer session scoping flows through desktop, web, and settings: APIs accept optional VSCode sidebar stops injecting tool/approval data via New agent primitives include accessibility snapshot refs, model capability cards, and validation contract progress/diff helpers. Compaction read-restore exclusions honor append-system-prompt paths per profile/cwd. Widespread logs use static secret masking; agent transcript save uses atomic JSON write. Reviewed by Cursor Bugbot for commit bdc16ba. Bugbot is set up for automated code reviews on this repo. Configure here. |
d49c2cc to
2a4c56c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Docker abort ignores container process
- DockerSandbox now records the in-container child PID, forwards aborts with a second docker exec, and routes abortable exec() calls through the same cancellation path.
You can send follow-ups to the cloud agent here.
haasonsaas
left a comment
There was a problem hiding this comment.
🔒 Hermes automated security scan flagged this PR.
🟠 Unsafe patterns (review):
src/tools/bash.ts— exec():const result = await sandbox.exec(interpolatedCommand, cwd, env, signal);test/packages/core/daytona-sandbox.test.ts— exec():const result = await sandbox.exec(test/sandbox/native-sandbox-max-buffer.test.ts— exec():const promise = sandbox.exec("gh api");
Automated gitleaks + pattern scan. Dismiss this review if it's a false positive.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 610758ac5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
… policy Restore the recursive URL scan over the full bash args (including the command string) alongside the bash-token aware extractor. The token-aware path alone misses URLs embedded mid-string in shell arguments (e.g. curl "see https://... here", echo "https://...", heredocs), which let enterprise network policy be bypassed. Union both scans so neither path can be evaded independently. Addresses Codex P1 finding on PR #781.
|
RESOLVED in evalops/maestro-internal#2773 (2026-06-17). Internal now has the same union-of-scans posture as the public mirror; the next sync will not re-introduce the regression. Original (Codex priority-one finding, addressed in cef6e3b): restored the recursive URL scan over the bash args (including the command string) while keeping the bash-token aware extractor. The two scans are now unioned and deduped, so URLs embedded mid-string ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cef6e3b80e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e36ce74159
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e36ce74 to
fb4cfd3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Daytona exec ignores abort signal
- DaytonaSandbox.exec now always routes signaled executions through execWithSession so unsupported session APIs fail fast instead of silently ignoring cancellation.
You can send follow-ups to the cloud agent here.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
7ace409 to
43290df
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Summary
evalops/maestro-internalevalops/maestroas a generated public mirror of the private source of truth173e8a0d1c0b79ba4d9d8a76e1aa68a155727fd4e18fb040ace9cad9fbfcb81903938a54cf5825d0460file(s) to copy/update and0stale file(s) to delete1Source-of-truth status
Public Mirror Drift Audit
@evalops/maestrohttps://github.com/evalops/maestro-internal@main (173e8a0d1c0b)https://github.com/evalops/maestro@main (e9efb25f35e6)4600public_projection_has_driftSample Changed Paths
Guidance
Let internal main generate and merge the public sync PR before relying on public main.
Drift sample
Public-only commits since last generated sync
Validation
sync-public-release-mirrorworkflow inpublic-treemodeTest Plan
sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prcheck confirms internal source PR lineageStaged Rollout
evalops/maestro-internal@173e8a0d1c0b79ba4d9d8a76e1aa68a155727fd4, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.Supersedes
173e8a0d1c0b79ba4d9d8a76e1aa68a155727fd4