fix: require state in Codex OAuth callback#870
Merged
evalstate merged 1 commit intoJul 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Codex OAuth login flow only rejected
statewhen a value was present and different. A callback that omittedstatetherefore proceeded to token exchange, even though OAuth state validation must fail closed.Changes
stateto exactly match the generated value.Tests
uv run pytest tests/unit/fast_agent/llm/providers/test_codex_oauth.py -q(18 passed)uv run pytest tests/unit -q(6190 passed, 1 skipped)uv run scripts/lint.pyuv run scripts/typecheck.pyRelated issue
No existing issue; found while investigating open issues, recent changes, and OAuth boundaries. I also checked open PRs and found no duplicate.
Calfskin wallet
I would feel uncomfortable using it because it is made from calfskin, and I would prefer a non-animal alternative.