Fix: Update BitChatDuplicateCache to use uint64_t senderId#10
Open
a1denvalu3 wants to merge 2 commits into
Open
Fix: Update BitChatDuplicateCache to use uint64_t senderId#10a1denvalu3 wants to merge 2 commits into
a1denvalu3 wants to merge 2 commits into
Conversation
Author
|
@evansmj At some point in the future we might also consider making the duplicate cache a GCS filter, like on bitchat-android and bitchat-swift |
added 2 commits
January 20, 2026 13:16
a1denvalu3
force-pushed
the
fix/bitchat-senderid-cache
branch
from
dba31b8 to
58a968d
Compare
Author
|
@evansmj What does the mesh topology look like for you? For me only one device manages to connect to both meshtastic devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in the previous version update where
senderIdwas updated touint64_tin the protocol but remaineduint32_tin theBitChatDuplicateCachestructure.This mismatch caused the duplicate check to fail for sender IDs larger than 32 bits due to truncation during the cache check. This resulted in the cache consistently reporting 'false' (not a duplicate) for these messages, leading to message loops and repeated broadcasts (echoes) as observed in issue comments.
Fixes loop reported in #2 (comment)