Skip to content

fix: use max() for penalty scaling floor (closes #75) #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andig merged 2 commits into from
May 31, 2026
Merged

fix: use max() for penalty scaling floor (closes #75) #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e8acdd
fix: use max() for penalty scaling floor (closes #75)
andig May 31, 2026
c38aaff
Apply suggestion from @andig
andig May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/optimizer/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,20 @@ def __init__(self, strategy: OptimizationStrategy, grid: GridConfig, batteries:
self.min_import_price = np.min(self.time_series.p_N)
self.max_import_price = np.max(self.time_series.p_N)

# scaling for penalty parameters. Make sure goal_penalty is always positive
self.prc_e_goal_pen = np.min([self.max_import_price, 0.1e-3]) * 10e1
self.prc_p_goal_pen = np.min([self.max_import_price, 0.1e-3]) * np.max(self.time_series.dt) / 3600 * 10e1
self.prc_soc_exc_pen = np.min([self.max_import_price, 0.1e-3]) * 10e2
# scaling base for penalty parameters. Make sure goal_penalty is always positive.
penalty_base = np.max([self.max_import_price, 0.1e-3])

# scaling for penalty parameters
self.prc_e_goal_pen = penalty_base * 10e1
self.prc_p_goal_pen = penalty_base * np.max(self.time_series.dt) / 3600 * 10e1
self.prc_soc_exc_pen = penalty_base * 10e2

# penalty for exceeding grid import limit. Result shall not become infeasible but report the violation
# with helpful information
self.prc_e_grid_imp_pen = np.min([self.max_import_price, 0.1e-3]) * 10e1
self.prc_e_grid_imp_pen = penalty_base * 10e1
# penalty for exceeding the grid export limit. Result shall not become infeasible but report the 'lost'
# solar power
self.prc_e_grid_exp_pen = np.min([self.max_import_price, 0.1e-3]) * 10e1
self.prc_e_grid_exp_pen = penalty_base * 10e1

# if there is a demand rate given in the input, the grid import limit will be interpreted as the
# threshold beyond wich the demand rate is to be applied. Compute a demand rate flag for use in the
Expand Down
Loading