Skip to content

fix(style): do not use core::iter::once() for chaining#682

Merged
samueltardieu merged 1 commit intomainfrom
push-mqnlrxvyzwrt
Jun 1, 2025
Merged

fix(style): do not use core::iter::once() for chaining#682
samueltardieu merged 1 commit intomainfrom
push-mqnlrxvyzwrt

Conversation

@samueltardieu
Copy link
Copy Markdown
Member

@samueltardieu samueltardieu commented Jun 1, 2025

A single element array also implements IntoIterator.

Summary by CodeRabbit

No user-facing changes in this release.

A single element array also implements `IntoIterator`.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 1, 2025

Walkthrough

The change updates the implementation of the connected_components method by removing the use of std::iter::once and replacing it with a single-element array to include the start node in the iterator chain. No public interfaces or exported entities are altered.

Changes

File(s) Change Summary
src/undirected/connected_components.rs Replaced std::iter::once with a single-element array in iterator chain; removed unused import.

Poem

A hop, a skip, a single node,
Once was "once," now arrays bestowed.
Connections found, components clear,
The code is neat, the logic dear.
With every hop, the graph is scanned,
By clever paws and gentle hand. 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd809a7 and 66c0ab3.

📒 Files selected for processing (1)
  • src/undirected/connected_components.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Test with minimal versions
  • GitHub Check: Test suite (beta)
  • GitHub Check: Test suite (stable)
  • GitHub Check: Test suite (nightly)
  • GitHub Check: Extra tests in release mode
  • GitHub Check: Test suite (msrv)
  • GitHub Check: benchmarks
🔇 Additional comments (2)
src/undirected/connected_components.rs (2)

136-139: Approve: use single-element array for chaining
Replacing std::iter::once(s.clone()) with .chain([s.clone()]) is idiomatic, removes an extra import, and keeps the logic identical.


136-139:

Details

✅ Verification successful

Verify MSRV compatibility
Array IntoIterator (i.e., [T; 1]) was stabilized in Rust 1.53. Please ensure that this crate’s minimum supported Rust version (MSRV) is ≥ 1.53 to avoid breaking older toolchains.

To check the declared MSRV in your Cargo.toml (if any), you can run:


🏁 Script executed:

#!/bin/bash
# Check for a `rust-version` field in Cargo.toml
grep -n '^rust-version' Cargo.toml

Length of output: 63


MSRV verification passed
The crate’s rust-version = "1.85.0" (in Cargo.toml) is ≥ 1.53, so the [T; 1] IntoIterator usage is supported. No changes needed.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 1, 2025

CodSpeed Performance Report

Merging #682 will improve performances by 23.78%

Comparing push-mqnlrxvyzwrt (66c0ab3) with main (dd809a7)

Summary

⚡ 5 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
Compare kuhn_munkres with different input sizes[128] 2.1 ms 1.7 ms +23.78%
Compare kuhn_munkres with different input sizes[256] 23 ms 19.1 ms +20.1%
Compare kuhn_munkres with different input sizes[32] 125.7 µs 108.3 µs +16.12%
Compare kuhn_munkres with different input sizes[512] 532.6 ms 453.7 ms +17.39%
Compare kuhn_munkres with different input sizes[64] 585.5 µs 488.2 µs +19.93%

@samueltardieu samueltardieu added this pull request to the merge queue Jun 1, 2025
Merged via the queue into main with commit 01b6619 Jun 1, 2025
14 checks passed
@samueltardieu samueltardieu deleted the push-mqnlrxvyzwrt branch June 1, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant